From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jiri Slaby <jirislaby@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Char: cyclades, remove bogus iomap
Date: Mon, 18 Aug 2008 22:38:28 +0100 [thread overview]
Message-ID: <20080818223828.29b3adac@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20080818144438.e3eab97a.akpm@linux-foundation.org>
On Mon, 18 Aug 2008 14:44:38 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 14 Aug 2008 18:25:52 +0200
> Jiri Slaby <jirislaby@gmail.com> wrote:
>
> > readl/writel are not expected to accept iomap return value. Replace
> > bogus mapping by standard ioremap.
>
> Confused. What's wrong with doing readl(pci_iomap(...))? There are a
> fair number of drivers doing this..
That was discussed some time ago and we fixed a few then.
There is no guarantee that a platform chooses to implement iomaps such
that an iomap cookie is valid for readl/writel. It happens to work on the
current generic implementation.
Alan
prev parent reply other threads:[~2008-08-18 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 16:25 Jiri Slaby
2008-08-14 16:25 ` [PATCH 2/3] Char: sx, fix io unmapping Jiri Slaby
2008-08-14 16:25 ` [PATCH 3/3] Char: sx, remove bogus iomap Jiri Slaby
2008-08-18 21:44 ` [PATCH 1/3] Char: cyclades, " Andrew Morton
2008-08-18 21:38 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818223828.29b3adac@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®