From: Andi Kleen <andi@firstfloor.org>
To: torvalds@osdl.org, mingo@elte.hu, linux-kernel@vger.kernel.org
Cc: Trond.Myklebust@netapp.com
Subject: [PATCH] Don't trigger softlockup detector on network fs blocked tasks
Date: Fri, 29 Aug 2008 20:06:23 +0200 [thread overview]
Message-ID: <20080829180623.GA22247@basil.nowhere.org> (raw)
Don't trigger softlockup detector on network fs blocked tasks
Pulling the ethernet cable on a 2.6.27-rc system with NFS mounts
currently leads to an ongoing flood of soft lockup detector backtraces
for all tasks blocked on the NFS mounts when the hickup takes
longer than 120s.
I don't think NFS problems should be all that noisy.
Luckily there's a reasonably easy way to distingush this case.
Don't report task softlockup warnings for tasks in TASK_KILLABLE
state, which is used by the network file systems.
I believe this patch is a 2.6.27 candidate.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Index: linux-2.6.27-rc4-misc/kernel/softlockup.c
===================================================================
--- linux-2.6.27-rc4-misc.orig/kernel/softlockup.c
+++ linux-2.6.27-rc4-misc/kernel/softlockup.c
@@ -180,6 +180,10 @@ static void check_hung_task(struct task_
if (t->flags & PF_FROZEN)
return;
+ /* Don't check for tasks waiting on network file systems like NFS */
+ if (t->state & TASK_KILLABLE)
+ return;
+
if (switch_count != t->last_switch_count || !t->last_switch_timestamp) {
t->last_switch_count = switch_count;
t->last_switch_timestamp = now;
reply other threads:[~2008-08-29 18:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080829180623.GA22247@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®