mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Don't trigger softlockup detector on network fs blocked tasks
@ 2008-08-29 18:06 Andi Kleen
  0 siblings, 0 replies; only message in thread
From: Andi Kleen @ 2008-08-29 18:06 UTC (permalink / raw)
  To: torvalds, mingo, linux-kernel; +Cc: Trond.Myklebust

Don't trigger softlockup detector on network fs blocked tasks

Pulling the ethernet cable on a 2.6.27-rc system with NFS mounts 
currently leads to an ongoing flood of soft lockup detector backtraces
for all tasks blocked on the NFS mounts when the hickup takes
longer than 120s.

I don't think NFS problems should be all that noisy.

Luckily there's a reasonably easy way to distingush this case.

Don't report task softlockup warnings for tasks in TASK_KILLABLE
state, which is used by the network file systems.

I believe this patch is a 2.6.27 candidate.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

Index: linux-2.6.27-rc4-misc/kernel/softlockup.c
===================================================================
--- linux-2.6.27-rc4-misc.orig/kernel/softlockup.c
+++ linux-2.6.27-rc4-misc/kernel/softlockup.c
@@ -180,6 +180,10 @@ static void check_hung_task(struct task_
 	if (t->flags & PF_FROZEN)
 		return;
 
+	/* Don't check for tasks waiting on network file systems like NFS */
+	if (t->state & TASK_KILLABLE)
+		return;
+
 	if (switch_count != t->last_switch_count || !t->last_switch_timestamp) {
 		t->last_switch_count = switch_count;
 		t->last_switch_timestamp = now;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-08-29 18:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-29 18:06 [PATCH] Don't trigger softlockup detector on network fs blocked tasks Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®