mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Albert Cahalan <acahalan@gmail.com>,
	Alexey Dobriyan <adobriyan@openvz.org>,
	Michael Kerrisk <mtk.manpages@googlemail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: don't confuse /bin/ps by zombie delay_group_leader's
Date: Sun, 31 Aug 2008 18:07:53 -0700 (PDT)	[thread overview]
Message-ID: <20080901010753.8FA4D154243@magilla.localdomain> (raw)
In-Reply-To: Oleg Nesterov's message of  Saturday, 30 August 2008 21:08:41 +0400 <20080830170841.GA7887@tv-sign.ru>

I don't think it's right to change /proc/pid/task/tid/status this way.
The real status is true and correct for the individual task, no matter what.
If you want to change /proc/pid/status, then you ought to split it into
proc_tgid_status and proc_tid_status variants to differ this way.

I don't really have an opinion either way about this for /proc/pid/status.
We've known it behaved this way for a very long time, and I've always
considered it procps's problem to display such situations in ways that
users find most useful.  It can already quickly tell that situation by a
"Threads:" line with >1 when "State:" says "Z".  If you do change it, it
might be nicer to display it as a (compatible) special case:

State:	S (delayed-leader)


Thanks,
Roland

  reply	other threads:[~2008-09-01  1:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-30 17:08 Oleg Nesterov
2008-09-01  1:07 ` Roland McGrath [this message]
2008-09-01 10:06   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080901010753.8FA4D154243@magilla.localdomain \
    --to=roland@redhat.com \
    --cc=acahalan@gmail.com \
    --cc=adobriyan@openvz.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@googlemail.com \
    --cc=oleg@tv-sign.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®