Re: [PATCH] proc: don't confuse /bin/ps by zombie delay_group_leader's

[Oleg Nesterov <oleg@tv-sign.ru>]

On 08/31, Roland McGrath wrote:
>

(re-ordered)

> We've known it behaved this way for a very long time, and I've always
> considered it procps's problem to display such situations in ways that
> users find most useful.  It can already quickly tell that situation by a
> "Threads:" line with >1 when "State:" says "Z".

Agreed. It is much better to change /bin/ps and do not touch the kernel.
Albert, what do you think?

Please ignore this patch.

> I don't think it's right to change /proc/pid/task/tid/status this way.
> The real status is true and correct for the individual task, no matter what.
> If you want to change /proc/pid/status, then you ought to split it into
> proc_tgid_status and proc_tid_status variants to differ this way.

Perhaps yes, but

> If you do change it, it
> might be nicer to display it as a (compatible) special case:
>
> State:	S (delayed-leader)

Or "Z (delayed-leader)" if we fix ps. In this case both /proc/pid/status
and /proc/pid/task/tid/status can report the same state.

Oleg.