Re: [PATCH] x86: order functions in cpu/common.c and cpu/common_64.c

[Ingo Molnar <mingo@elte.hu>]

* Ingo Molnar <mingo@elte.hu> wrote:

> hm, something in your patch series is early-crashing tip/master with 
> this config:
> 
>  http://redhat.com/~mingo/misc/config-Thu_Sep__4_21_23_20_CEST_2008.bad
> 
> the early-RIP is 0xffffffff804365b0:
> 
> ffffffff8043656a <proc_bus_pci_release>:
> 
> ffffffff804365b0:       be d0 00 00 00          mov    $0xd0,%esi
> ffffffff804365b5:       e8 ad 28 e7 ff          callq  ffffffff802a8e67 <kmem_cache_alloc>
> 
> fault 0xd, general protection fault. Given that it's an immediate 
> constant load, something really serious happened.

ah, that's _another_ -tip testbox that broke at the same time, with a 
different kernel image. The RIP that corresponds to this box is 
0xffffffff80420470:

ffffffff8042045b <strnlen>:
ffffffff8042045b:       55                      push   %rbp

ffffffff80420470:       80 38 00                cmpb   $0x0,(%rax)


which could be consistent with the printk messup ...

> i've pushed out the broken tree into tip/tmp.master.broken (havent 
> updated tip/master with the breakage). I've removed the broken printk 
> in kernel/resource.c that Andrew found, see commit 06e44f6af324 - so 
> that's not the cause.

i've double checked that 06e44f6af324 is applied. I'll bisect this.

	Ingo