mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: order functions in cpu/common.c and cpu/common_64.c
Date: Thu, 4 Sep 2008 13:07:34 -0700	[thread overview]
Message-ID: <86802c440809041307i24cce782u4937d6fd2311c6f@mail.gmail.com> (raw)
In-Reply-To: <20080904200421.GA24295@elte.hu>

On Thu, Sep 4, 2008 at 1:04 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Ingo Molnar <mingo@elte.hu> wrote:
>
>> > i've pushed out the broken tree into tip/tmp.master.broken (havent
>> > updated tip/master with the breakage). I've removed the broken
>> > printk in kernel/resource.c that Andrew found, see commit
>> > 06e44f6af324 - so that's not the cause.
>>
>> i've double checked that 06e44f6af324 is applied. I'll bisect this.
>
> bisection came up with:
>
>  # good: [8bfd9710] Merge branch 'x86/xsave'
>  # bad:  [06e44f6a] IO resources: fix/remove printk
>  # good: [282a5f84] Merge branch 'irq/sparseirq'
>  # bad:  [a0854a46] x86: make 32bit support show_msr like 64 bit
>  # good: [5031088d] x86: delay early cpu initialization until cpuid is
>  # good: [9d31d35b] x86: order functions in cpu/common.c and cpu/commo
>  # bad:  [10a434fc] x86: remove cpu_vendor_dev
>
> | 10a434fcb23a57c385177a0086955fae01003f64 is first bad commit
> | commit 10a434fcb23a57c385177a0086955fae01003f64
> | Author: Yinghai Lu <yhlu.kernel@gmail.com>
> | Date:   Thu Sep 4 21:09:45 2008 +0200
> |
> |     x86: remove cpu_vendor_dev
>
> and the thing is, 10a434fc is way too big:
>
> | 15 files changed, 106 insertions(+), 106 deletions(-)
>
> and it's not obvious at first (neither at second) sight what the problem
> is. You really need to start doing much smaller patches for such
> critical/hard-to-debug code areas.
>
could be alignment again...

YH

  reply	other threads:[~2008-09-04 20:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-02  5:05 Yinghai Lu
2008-09-04 19:12 ` Ingo Molnar
2008-09-04 19:37   ` Ingo Molnar
2008-09-04 19:41     ` Ingo Molnar
2008-09-04 19:59       ` Yinghai Lu
2008-09-04 20:04       ` Ingo Molnar
2008-09-04 20:07         ` Yinghai Lu [this message]
2008-09-04 20:32           ` Yinghai Lu
2008-09-04 20:37             ` Yinghai Lu
2008-09-04 20:58               ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440809041307i24cce782u4937d6fd2311c6f@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®