Re: [PATCH] ucb1400_ts depends SND_AC97_BUS

[Randy Dunlap <randy.dunlap@oracle.com>]

On Fri, 05 Sep 2008 00:37:17 -0400 (EDT) Nicolas Pitre wrote:

> On Thu, 4 Sep 2008, Randy Dunlap wrote:
> 
> > On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
> > 
> > > On Sat, 9 Dec 2006, Randy Dunlap wrote:
> > > 
> > > > On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
> > > > 
> > > > > Please consider what SND_CONFIG_AC97_BUS corresponds to.  It is 
> > > > > sound/pci/ac97/ac97_bus.c and if you look into this file you'll see that 
> > > > > it is perfectly buildable even if sound is entirely configured out, just 
> > > > > like some lib code would be.
> > > > 
> > > > OK.  Should it (CONFIG_SND_AC97_BUS -> sound/pci/ac97/ac97_bus.c)
> > > > be buildable when sound is disabled?
> > > 
> > > Yes.
> > > 
> > > > If so, where should it be moved to (since afaik, make won't even
> > > > descend into sound/ if SOUND=n; I don't see that changing
> > > > any time soon).
> > > 
> > > What about this patch?
> > 
> > Can we get this patch or some patch into the input tree for linux-next?
> 
> This patch is commit e1036502e5263851259d147771226161e5ccc85a and 
> appeared in mainline almost 2 years ago.

Ack.  Sorry about that.  Wrong ucb thread.

ucb1400_core still has build errors in linux-next
since it uses ac97_bus_type even when CONFIG_SOUND=n.


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/