From: Nicolas Pitre <nico@cam.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Dmitry Torokhov <dtor@insightbb.com>,
lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>,
linux-next@vger.kernel.org
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Fri, 05 Sep 2008 01:27:23 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0809050125500.23787@xanadu.home> (raw)
In-Reply-To: <20080904214444.0dccf859.randy.dunlap@oracle.com>
On Thu, 4 Sep 2008, Randy Dunlap wrote:
> On Fri, 05 Sep 2008 00:37:17 -0400 (EDT) Nicolas Pitre wrote:
>
> > On Thu, 4 Sep 2008, Randy Dunlap wrote:
> >
> > > On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
> > >
> > > > On Sat, 9 Dec 2006, Randy Dunlap wrote:
> > > >
> > > > > On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
> > > > >
> > > > > > Please consider what SND_CONFIG_AC97_BUS corresponds to. It is
> > > > > > sound/pci/ac97/ac97_bus.c and if you look into this file you'll see that
> > > > > > it is perfectly buildable even if sound is entirely configured out, just
> > > > > > like some lib code would be.
> > > > >
> > > > > OK. Should it (CONFIG_SND_AC97_BUS -> sound/pci/ac97/ac97_bus.c)
> > > > > be buildable when sound is disabled?
> > > >
> > > > Yes.
> > > >
> > > > > If so, where should it be moved to (since afaik, make won't even
> > > > > descend into sound/ if SOUND=n; I don't see that changing
> > > > > any time soon).
> > > >
> > > > What about this patch?
> > >
> > > Can we get this patch or some patch into the input tree for linux-next?
> >
> > This patch is commit e1036502e5263851259d147771226161e5ccc85a and
> > appeared in mainline almost 2 years ago.
>
> Ack. Sorry about that. Wrong ucb thread.
>
> ucb1400_core still has build errors in linux-next
> since it uses ac97_bus_type even when CONFIG_SOUND=n.
What about this?
diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 6e1e8c6..22cf319 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -219,7 +219,6 @@ config TOUCHSCREEN_ATMEL_TSADCC
config TOUCHSCREEN_UCB1400
tristate "Philips UCB1400 touchscreen"
- select AC97_BUS
depends on UCB1400_CORE
help
This enables support for the Philips UCB1400 touchscreen interface.
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 5dba165..70355d3 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -52,6 +52,7 @@ config HTC_PASIC3
config UCB1400_CORE
tristate "Philips UCB1400 Core driver"
+ select AC97_BUS
help
This enables support for the Philips UCB1400 core functions.
The UCB1400 is an AC97 audio codec.
Nicolas
prev parent reply other threads:[~2008-09-05 5:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-09 8:36 Randy Dunlap
2006-12-10 2:50 ` Dmitry Torokhov
2006-12-10 2:57 ` Randy Dunlap
2006-12-10 3:05 ` Dmitry Torokhov
2006-12-10 3:17 ` Nicolas Pitre
2006-12-10 5:09 ` Randy Dunlap
2006-12-11 3:55 ` Nicolas Pitre
2006-12-11 4:45 ` Randy Dunlap
2008-09-05 2:57 ` Randy Dunlap
2008-09-05 4:37 ` Nicolas Pitre
2008-09-05 4:44 ` Randy Dunlap
2008-09-05 5:09 ` Nicolas Pitre
2008-09-05 6:46 ` Takashi Iwai
2008-09-05 14:52 ` Nicolas Pitre
2008-09-05 16:26 ` Takashi Iwai
2008-09-05 16:32 ` Nicolas Pitre
2008-09-05 17:17 ` Takashi Iwai
2008-09-05 18:33 ` Dmitry Torokhov
2008-09-06 9:54 ` Takashi Iwai
2008-09-05 21:09 ` Randy Dunlap
2008-09-06 9:53 ` Takashi Iwai
2008-09-05 5:27 ` Nicolas Pitre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0809050125500.23787@xanadu.home \
--to=nico@cam.org \
--cc=akpm@osdl.org \
--cc=dtor@insightbb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®