* [PATCH -next] x86: make setup_xstate_init() __init
@ 2008-08-30 2:03 Alexey Dobriyan
2008-09-06 17:01 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2008-08-30 2:03 UTC (permalink / raw)
To: mingo; +Cc: linux-kernel
WARNING: vmlinux.o(.text+0x22453): Section mismatch in reference from the function setup_xstate_init() to the function .init.text:__alloc_bootmem()
The function setup_xstate_init() references the function __init __alloc_bootmem().
This is often because setup_xstate_init lacks a __init annotation or the annotation of __alloc_bootmem is wrong.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
arch/x86/kernel/xsave.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/kernel/xsave.c
+++ b/arch/x86/kernel/xsave.c
@@ -272,7 +272,7 @@ void __cpuinit xsave_init(void)
/*
* setup the xstate image representing the init state
*/
-void setup_xstate_init(void)
+static void __init setup_xstate_init(void)
{
init_xstate_buf = alloc_bootmem(xstate_size);
init_xstate_buf->i387.mxcsr = MXCSR_DEFAULT;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] x86: make setup_xstate_init() __init
2008-08-30 2:03 [PATCH -next] x86: make setup_xstate_init() __init Alexey Dobriyan
@ 2008-09-06 17:01 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-09-06 17:01 UTC (permalink / raw)
To: Alexey Dobriyan
Cc: mingo, linux-kernel, Thomas Gleixner, H. Peter Anvin, Suresh Siddha
* Alexey Dobriyan <adobriyan@gmail.com> wrote:
> WARNING: vmlinux.o(.text+0x22453): Section mismatch in reference from the function setup_xstate_init() to the function .init.text:__alloc_bootmem()
> The function setup_xstate_init() references the function __init __alloc_bootmem().
> This is often because setup_xstate_init lacks a __init annotation or the annotation of __alloc_bootmem is wrong.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> arch/x86/kernel/xsave.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to tip/x86/xsave, thanks Alexey.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-06 17:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-30 2:03 [PATCH -next] x86: make setup_xstate_init() __init Alexey Dobriyan
2008-09-06 17:01 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome