From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Magnus Damm <magnus.damm@gmail.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Mundt <lethal@linux-sh.org>,
video4linux-list@redhat.com, Magnus Damm <damm@igel.co.jp>
Subject: [patch 1/2] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA
Date: Wed, 10 Sep 2008 22:15:18 +0200 [thread overview]
Message-ID: <20080910201530.880263695@mail.of.borg> (raw)
In-Reply-To: <20080910201517.233690597@mail.of.borg>
[-- Attachment #1: VIDEO_SH_MOBILE_CEU-needs-DMA.diff --]
[-- Type: text/plain, Size: 1371 bytes --]
From: Geert Uytterhoeven <geert@linux-m68k.org>
commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342):
sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced
VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the
dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG.
Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Magnus Damm <damm@igel.co.jp>
---
This broke m68k allmodconfig (which still selects Sun-3). I assume it also
affects the other NO_DMA platforms like h8300, m32r, s390, and PCI-less
SPARC?
drivers/media/video/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -968,7 +968,7 @@ config VIDEO_PXA27x
config VIDEO_SH_MOBILE_CEU
tristate "SuperH Mobile CEU Interface driver"
- depends on VIDEO_DEV
+ depends on VIDEO_DEV && HAS_DMA
select SOC_CAMERA
select VIDEOBUF_DMA_CONTIG
---help---
--
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2008-09-10 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 20:15 [patch 0/2] m68k patches for 2.6.27 Geert Uytterhoeven
2008-09-10 20:15 ` Geert Uytterhoeven [this message]
2008-09-10 20:15 ` [patch 2/2] m68k: Update defconfigs for 2.6.27-rc6 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080910201530.880263695@mail.of.borg \
--to=geert@linux-m68k.org \
--cc=damm@igel.co.jp \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mchehab@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®