[PATCH] fastboot: fix blackfin breakage due to vmlinux.lds change

[PATCH] fastboot: fix blackfin breakage due to vmlinux.lds change

[Arjan van de Ven]

Hi,

the patch below fixes the fastboot bug as reported by Mike Frysinger;
I've commited this to
git://git.kernel.org/pub/scm/linux/kernel/git/arjan/linux-2.6-fastboot.git

Ingo, please also add to -tip


>From 16aeda33acbb711863d8fff78c15b32ad0d4aa89 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@linux.intel.com>
Date: Wed, 10 Sep 2008 08:22:26 -0700
Subject: [PATCH] fastboot: fix blackfin breakage due to vmlinux.lds change

As reported by Mike Frysinger, the vmlinux.lds changes should
have used VMLINUX_SYMBOL()...

Reported-by: Mike Frysinger <vapier.adi@gmail.com>
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
 include/asm-generic/vmlinux.lds.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 020c641..f32418f 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -373,11 +373,11 @@
   	*(.initcall5s.init)						\
 	*(.initcallrootfs.init)						\
 	*(.initcall6s.init)						\
-	__async_initcall_start = .;					\
+	VMLINUX_SYMBOL(__async_initcall_start) = .;			\
 	*(.initcall6a.init)						\
-	__async_initcall_end = .;					\
+	VMLINUX_SYMBOL(__async_initcall_end) = .;			\
   	*(.initcall6.init)						\
-	__device_initcall_end = .;					\
+	VMLINUX_SYMBOL(__device_initcall_end) = .;			\
   	*(.initcall7.init)						\
   	*(.initcall7s.init)
 
-- 
1.5.5.1




-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

Re: [PATCH] fastboot: fix blackfin breakage due to vmlinux.lds change

[Bryan Wu]

On Wed, Sep 10, 2008 at 11:25 PM, Arjan van de Ven <arjan@infradead.org> wrote:
> Hi,
>
> the patch below fixes the fastboot bug as reported by Mike Frysinger;
> I've commited this to
> git://git.kernel.org/pub/scm/linux/kernel/git/arjan/linux-2.6-fastboot.git
>
> Ingo, please also add to -tip
>
>
> From 16aeda33acbb711863d8fff78c15b32ad0d4aa89 Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@linux.intel.com>
> Date: Wed, 10 Sep 2008 08:22:26 -0700
> Subject: [PATCH] fastboot: fix blackfin breakage due to vmlinux.lds change
>
> As reported by Mike Frysinger, the vmlinux.lds changes should
> have used VMLINUX_SYMBOL()...
>

Thanks a lot, Mike and Arjan. This issue was found by Mike's auto
nightly building machine.

Acked-by: Bryan Wu <cooloney@kernel.org>

> Reported-by: Mike Frysinger <vapier.adi@gmail.com>
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> ---
>  include/asm-generic/vmlinux.lds.h |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 020c641..f32418f 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -373,11 +373,11 @@
>        *(.initcall5s.init)                                             \
>        *(.initcallrootfs.init)                                         \
>        *(.initcall6s.init)                                             \
> -       __async_initcall_start = .;                                     \
> +       VMLINUX_SYMBOL(__async_initcall_start) = .;                     \
>        *(.initcall6a.init)                                             \
> -       __async_initcall_end = .;                                       \
> +       VMLINUX_SYMBOL(__async_initcall_end) = .;                       \
>        *(.initcall6.init)                                              \
> -       __device_initcall_end = .;                                      \
> +       VMLINUX_SYMBOL(__device_initcall_end) = .;                      \
>        *(.initcall7.init)                                              \
>        *(.initcall7s.init)
>
> --
> 1.5.5.1
>
>
>
>
> --
> Arjan van de Ven        Intel Open Source Technology Centre
> For development, discussion and tips for power savings,
> visit http://www.lesswatts.org
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: [PATCH] fastboot: fix blackfin breakage due to vmlinux.lds change

[Ingo Molnar]

* Bryan Wu <cooloney@kernel.org> wrote:

> On Wed, Sep 10, 2008 at 11:25 PM, Arjan van de Ven <arjan@infradead.org> wrote:
> > Hi,
> >
> > the patch below fixes the fastboot bug as reported by Mike Frysinger;
> > I've commited this to
> > git://git.kernel.org/pub/scm/linux/kernel/git/arjan/linux-2.6-fastboot.git
> >
> > Ingo, please also add to -tip
> >
> >
> > From 16aeda33acbb711863d8fff78c15b32ad0d4aa89 Mon Sep 17 00:00:00 2001
> > From: Arjan van de Ven <arjan@linux.intel.com>
> > Date: Wed, 10 Sep 2008 08:22:26 -0700
> > Subject: [PATCH] fastboot: fix blackfin breakage due to vmlinux.lds change
> >
> > As reported by Mike Frysinger, the vmlinux.lds changes should
> > have used VMLINUX_SYMBOL()...
> >
> 
> Thanks a lot, Mike and Arjan. This issue was found by Mike's auto
> nightly building machine.
> 
> Acked-by: Bryan Wu <cooloney@kernel.org>

applied to tip/fastboot, thanks!

	Ingo