* [PATCH] i2c-dev: Return correct error code on class_create() failure
@ 2008-09-10 19:30 Sven Wegener
2008-09-11 11:04 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Sven Wegener @ 2008-09-10 19:30 UTC (permalink / raw)
To: Jean Delvare; +Cc: i2c, linux-kernel
We need to convert the error pointer from class_create(), else we'll return the
successful return code from register_chrdev() on failure.
Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
---
drivers/i2c/i2c-dev.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
index af4491f..307d976 100644
--- a/drivers/i2c/i2c-dev.c
+++ b/drivers/i2c/i2c-dev.c
@@ -583,8 +583,10 @@ static int __init i2c_dev_init(void)
goto out;
i2c_dev_class = class_create(THIS_MODULE, "i2c-dev");
- if (IS_ERR(i2c_dev_class))
+ if (IS_ERR(i2c_dev_class)) {
+ res = PTR_ERR(i2c_dev_class);
goto out_unreg_chrdev;
+ }
res = i2c_add_driver(&i2cdev_driver);
if (res)
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] i2c-dev: Return correct error code on class_create() failure
2008-09-10 19:30 [PATCH] i2c-dev: Return correct error code on class_create() failure Sven Wegener
@ 2008-09-11 11:04 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2008-09-11 11:04 UTC (permalink / raw)
To: Sven Wegener; +Cc: i2c, linux-kernel
Hi Sven,
On Wed, 10 Sep 2008 21:30:27 +0200 (CEST), Sven Wegener wrote:
> We need to convert the error pointer from class_create(), else we'll return the
> successful return code from register_chrdev() on failure.
>
> Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
> ---
> drivers/i2c/i2c-dev.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
> index af4491f..307d976 100644
> --- a/drivers/i2c/i2c-dev.c
> +++ b/drivers/i2c/i2c-dev.c
> @@ -583,8 +583,10 @@ static int __init i2c_dev_init(void)
> goto out;
>
> i2c_dev_class = class_create(THIS_MODULE, "i2c-dev");
> - if (IS_ERR(i2c_dev_class))
> + if (IS_ERR(i2c_dev_class)) {
> + res = PTR_ERR(i2c_dev_class);
> goto out_unreg_chrdev;
> + }
>
> res = i2c_add_driver(&i2cdev_driver);
> if (res)
Good catch. Patch applied, thanks.
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-11 11:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-10 19:30 [PATCH] i2c-dev: Return correct error code on class_create() failure Sven Wegener
2008-09-11 11:04 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome