* [PATCH] ibmasr: remove unnecessary spin_unlock()
@ 2008-09-13 9:47 Akinobu Mita
2008-09-15 11:12 ` Andrey Panin
0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2008-09-13 9:47 UTC (permalink / raw)
To: linux-kernel; +Cc: Wim Van Sebroeck, Andrey Panin
__asr_toggle() is always called with asr_lock held.
But there is unnecessary spin_unlock() call in __asr_toggle().
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Andrey Panin <pazke@donpac.ru>
---
drivers/watchdog/ibmasr.c | 1 -
1 file changed, 1 deletion(-)
Index: 2.6-git/drivers/watchdog/ibmasr.c
===================================================================
--- 2.6-git.orig/drivers/watchdog/ibmasr.c
+++ 2.6-git/drivers/watchdog/ibmasr.c
@@ -85,7 +85,6 @@ static void __asr_toggle(void)
outb(reg & ~asr_toggle_mask, asr_write_addr);
reg = inb(asr_read_addr);
- spin_unlock(&asr_lock);
}
static void asr_toggle(void)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ibmasr: remove unnecessary spin_unlock()
2008-09-13 9:47 [PATCH] ibmasr: remove unnecessary spin_unlock() Akinobu Mita
@ 2008-09-15 11:12 ` Andrey Panin
0 siblings, 0 replies; 2+ messages in thread
From: Andrey Panin @ 2008-09-15 11:12 UTC (permalink / raw)
To: Akinobu Mita; +Cc: linux-kernel, Wim Van Sebroeck
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
On 257, 09 13, 2008 at 06:47:19 +0900, Akinobu Mita wrote:
> __asr_toggle() is always called with asr_lock held.
> But there is unnecessary spin_unlock() call in __asr_toggle().
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> Cc: Andrey Panin <pazke@donpac.ru>
Acked-by: Andrey Panin <pazke@donpac.ru>
> ---
> drivers/watchdog/ibmasr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> Index: 2.6-git/drivers/watchdog/ibmasr.c
> ===================================================================
> --- 2.6-git.orig/drivers/watchdog/ibmasr.c
> +++ 2.6-git/drivers/watchdog/ibmasr.c
> @@ -85,7 +85,6 @@ static void __asr_toggle(void)
>
> outb(reg & ~asr_toggle_mask, asr_write_addr);
> reg = inb(asr_read_addr);
> - spin_unlock(&asr_lock);
> }
>
> static void asr_toggle(void)
>
--
Andrey Panin | Linux and UNIX system administrator
pazke@donpac.ru | PGP key: wwwkeys.pgp.net
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-15 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-13 9:47 [PATCH] ibmasr: remove unnecessary spin_unlock() Akinobu Mita
2008-09-15 11:12 ` Andrey Panin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome