mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Louis Rilling <Louis.Rilling@kerlabs.com>
Cc: Andrey Mirkin <major@openvz.org>,
	linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org
Subject: Re: [PATCH 8/9] Introduce functions to restart a process
Date: Sat, 13 Sep 2008 19:34:19 +0200	[thread overview]
Message-ID: <20080913173418.GA8822@ucw.cz> (raw)
In-Reply-To: <20080903143248.GU14473@hawkmoon.kerlabs.com>

Hi!

> > @@ -233,6 +234,26 @@ ENTRY(ret_from_fork)
> >  	CFI_ENDPROC
> >  END(ret_from_fork)
> >  
> > +ENTRY(i386_ret_from_resume)
> > +	CFI_STARTPROC
> > +	pushl %eax
> > +	CFI_ADJUST_CFA_OFFSET 4
> > +	call schedule_tail
> > +	GET_THREAD_INFO(%ebp)
> > +	popl %eax
> > +	CFI_ADJUST_CFA_OFFSET -4
> > +	movl (%esp), %eax
> > +	testl %eax, %eax
> > +	jz    1f
> > +	pushl %esp
> > +	call  *%eax
> > +	addl  $4, %esp
> > +1:
> > +	addl  $256, %esp

Can we do something with naming here? resume usually means 'resume
from s2ram'...

> > diff --git a/cpt/rst_process.c b/cpt/rst_process.c
> > new file mode 100644
> > index 0000000..6d47f3c
> > --- /dev/null
> > +++ b/cpt/rst_process.c
> > @@ -0,0 +1,277 @@

....and you are not even consistent. Plus, rst_ will probably be
understood as a reset by most people.

Hmmm... your syscalls get fd. What happens if I pass something like
/proc/self/maps to them?


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2008-09-13 17:34 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03 10:57 [PATCH 0/9] OpenVZ kernel based checkpointing/restart Andrey Mirkin
2008-09-03 10:57 ` [PATCH 1/9] Introduce trivial sys_checkpoint and sys_restore system calls Andrey Mirkin
2008-09-03 10:57   ` [PATCH 2/9] Make checkpoint/restart functionality modular Andrey Mirkin
2008-09-03 10:57     ` [PATCH 3/9] Introduce context structure needed during checkpointing/restart Andrey Mirkin
2008-09-03 10:57       ` [PATCH 4/9] Introduce container dump function Andrey Mirkin
2008-09-03 10:57         ` [PATCH 5/9] Introduce function to dump process Andrey Mirkin
2008-09-03 10:57           ` [PATCH 6/9] Introduce functions to dump mm Andrey Mirkin
2008-09-03 10:57             ` [PATCH 7/9] Introduce function for restarting a container Andrey Mirkin
2008-09-03 10:57               ` [PATCH 8/9] Introduce functions to restart a process Andrey Mirkin
2008-09-03 10:57                 ` [PATCH 9/9] Introduce functions to restore mm Andrey Mirkin
2008-09-03 14:32                 ` [PATCH 8/9] Introduce functions to restart a process Louis Rilling
2008-09-13 17:34                   ` Pavel Machek [this message]
2008-09-03 14:17             ` [PATCH 6/9] Introduce functions to dump mm Louis Rilling
2008-09-03 14:23         ` [PATCH 4/9] Introduce container dump function Serge E. Hallyn
2008-09-03 14:45           ` Andrey Mirkin
2008-09-03 12:29       ` [PATCH 3/9] Introduce context structure needed during checkpointing/restart Matthieu Fertré
2008-09-03 14:11         ` Andrey Mirkin
2008-09-03 13:56       ` Louis Rilling
2008-09-03 14:07         ` Andrey Mirkin
2008-09-03 14:13       ` Cedric Le Goater
2008-09-03 14:29         ` Andrey Mirkin
2008-09-03 14:27     ` [PATCH 2/9] Make checkpoint/restart functionality modular Serge E. Hallyn
2008-09-03 14:51       ` Andrey Mirkin
2008-09-03 11:44   ` [PATCH 1/9] Introduce trivial sys_checkpoint and sys_restore system calls Cedric Le Goater
2008-09-03 13:05     ` [Devel] " Andrey Mirkin
2008-09-03 12:28 ` [PATCH 0/9] OpenVZ kernel based checkpointing/restart Cedric Le Goater
2008-09-03 13:59   ` [Devel] " Andrey Mirkin
2008-09-04 22:55     ` Dave Hansen
2008-09-03 14:18   ` Serge E. Hallyn
2008-09-03 13:49 ` Louis Rilling
2008-09-03 14:06   ` Louis Rilling
2008-09-03 14:19     ` Andrey Mirkin
2008-09-03 14:26     ` Cedric Le Goater
2008-09-03 14:53       ` Andrey Mirkin
2008-09-04  8:14 ` Oren Laadan
2008-09-04 14:05 ` Dave Hansen
2008-10-17 23:33 ` Dave Hansen
2008-10-20 11:10   ` Louis Rilling
2008-10-20 13:25     ` Daniel Lezcano
2008-10-20 13:48       ` Cedric Le Goater
2008-10-20 13:49         ` Daniel Lezcano
2008-10-20 15:53       ` Oren Laadan
2008-10-20 16:37         ` Daniel Lezcano
2008-10-20 17:23           ` Serge E. Hallyn
2008-10-21  0:18             ` Oren Laadan
2008-10-21  0:58               ` Serge E. Hallyn
2008-10-21 13:24               ` Daniel Lezcano
2008-10-27 14:45           ` [Devel] " Andrey Mirkin
2008-10-20 16:51         ` Serge E. Hallyn
2008-10-21  9:36         ` Cedric Le Goater
2008-10-20 16:36     ` Dave Hansen
2008-10-20 12:14   ` [Devel] " Andrey Mirkin
2008-10-20 15:55     ` Dave Hansen
2008-10-27 14:07       ` Andrey Mirkin
2008-10-27 14:39         ` Oren Laadan
2008-10-30  6:02           ` Andrey Mirkin
2008-10-30 11:47             ` Louis Rilling
2008-10-30 17:08               ` Dave Hansen
2008-10-30 18:01                 ` Louis Rilling
2008-10-30 18:28                   ` Oren Laadan
2008-10-30 17:45               ` Oren Laadan
2008-10-30 18:14                 ` Louis Rilling
2008-10-30 18:32                   ` Oren Laadan
2008-10-31 10:37                     ` Louis Rilling
2008-10-30 14:08             ` Serge E. Hallyn
2008-10-30 17:03             ` Dave Hansen
2008-11-03 19:35         ` Oren Laadan
2008-10-20 17:17     ` Oren Laadan
2008-10-27 14:38       ` Andrey Mirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080913173418.GA8822@ucw.cz \
    --to=pavel@suse.cz \
    --cc=Louis.Rilling@kerlabs.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=major@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome