* [PATCH resend] input: Move map_to_7segment.h to include/linux
@ 2008-09-14 13:30 Atsushi Nemoto
2008-09-14 15:16 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Atsushi Nemoto @ 2008-09-14 13:30 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: Henk.Vergonet, linux-kernel, akpm
The map_to_7segment.h provides generic 7segment LED mappings and is
designed to be used by other drivers. Moving it to common area will
make it more usable.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Henk Vergonet <henk.vergonet@gmail.com>
---
This is renaming patch. I can send no-rename patch if requested.
drivers/input/misc/yealink.c | 2 +-
.../input/misc => include/linux}/map_to_7segment.h | 2 --
2 files changed, 1 insertions(+), 3 deletions(-)
rename {drivers/input/misc => include/linux}/map_to_7segment.h (99%)
diff --git a/drivers/input/misc/yealink.c b/drivers/input/misc/yealink.c
index facefd3..11b5c7e 100644
--- a/drivers/input/misc/yealink.c
+++ b/drivers/input/misc/yealink.c
@@ -52,8 +52,8 @@
#include <linux/module.h>
#include <linux/rwsem.h>
#include <linux/usb/input.h>
+#include <linux/map_to_7segment.h>
-#include "map_to_7segment.h"
#include "yealink.h"
#define DRIVER_VERSION "yld-20051230"
diff --git a/drivers/input/misc/map_to_7segment.h b/include/linux/map_to_7segment.h
similarity index 99%
rename from drivers/input/misc/map_to_7segment.h
rename to include/linux/map_to_7segment.h
index a424094..db45f7c 100644
--- a/drivers/input/misc/map_to_7segment.h
+++ b/include/linux/map_to_7segment.h
@@ -1,6 +1,4 @@
/*
- * drivers/usb/input/map_to_7segment.h
- *
* Copyright (c) 2005 Henk Vergonet <Henk.Vergonet@gmail.com>
*
* This program is free software; you can redistribute it and/or
--
1.5.6.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH resend] input: Move map_to_7segment.h to include/linux
2008-09-14 13:30 [PATCH resend] input: Move map_to_7segment.h to include/linux Atsushi Nemoto
@ 2008-09-14 15:16 ` Dmitry Torokhov
2008-09-15 13:57 ` Atsushi Nemoto
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2008-09-14 15:16 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: Henk.Vergonet, linux-kernel, akpm
Hi Atsushi,
On Sun, Sep 14, 2008 at 10:30:32PM +0900, Atsushi Nemoto wrote:
> The map_to_7segment.h provides generic 7segment LED mappings and is
> designed to be used by other drivers. Moving it to common area will
> make it more usable.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> Signed-off-by: Henk Vergonet <henk.vergonet@gmail.com>
Should we also export this header to userspace and install it with other
kernel headers?
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH resend] input: Move map_to_7segment.h to include/linux
2008-09-14 15:16 ` Dmitry Torokhov
@ 2008-09-15 13:57 ` Atsushi Nemoto
0 siblings, 0 replies; 3+ messages in thread
From: Atsushi Nemoto @ 2008-09-15 13:57 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: Henk.Vergonet, linux-kernel, akpm
On Sun, 14 Sep 2008 11:16:41 -0400, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> Hi Atsushi,
>
> On Sun, Sep 14, 2008 at 10:30:32PM +0900, Atsushi Nemoto wrote:
> > The map_to_7segment.h provides generic 7segment LED mappings and is
> > designed to be used by other drivers. Moving it to common area will
> > make it more usable.
> >
> > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> > Signed-off-by: Henk Vergonet <henk.vergonet@gmail.com>
>
> Should we also export this header to userspace and install it with other
> kernel headers?
Well, yes. I think so. It helps writing userspace programs which use
sysfs files. But for now I have no such plan, so I'm OK either
with/without the export.
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-15 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-14 13:30 [PATCH resend] input: Move map_to_7segment.h to include/linux Atsushi Nemoto
2008-09-14 15:16 ` Dmitry Torokhov
2008-09-15 13:57 ` Atsushi Nemoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®