From: Adrian Bunk <bunk@kernel.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-kernel@vger.kernel.org, Ulrich Drepper <drepper@redhat.com>,
Davide Libenzi <davidel@xmailserver.org>,
David Woodhouse <dwmw2@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] linux/inotify.h: do not include <linux/fcntl.h> in userspace
Date: Tue, 16 Sep 2008 15:58:02 +0300 [thread overview]
Message-ID: <20080916125802.GA15951@cs181140183.pp.htv.fi> (raw)
In-Reply-To: <1221567763-17060-1-git-send-email-kirill@shutemov.name>
On Tue, Sep 16, 2008 at 03:22:43PM +0300, Kirill A. Shutemov wrote:
> <linux/fcntl.h> conflicts with glibc's <fcntl.h>.
>
> It breaks building kdelibs, kdepim and pinot.
We should rather fix the actual bug.
What is the error message?
>...
> --- a/include/linux/inotify.h
> +++ b/include/linux/inotify.h
> @@ -7,8 +7,10 @@
> #ifndef _LINUX_INOTIFY_H
> #define _LINUX_INOTIFY_H
>
> +#ifdef __KERNEL__
> /* For O_CLOEXEC and O_NONBLOCK */
> #include <linux/fcntl.h>
> +#endif
>...
This breaks the header for users of IN_CLOEXEC/IN_NONBLOCK.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-09-16 12:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 12:22 Kirill A. Shutemov
2008-09-16 12:58 ` Adrian Bunk [this message]
2008-09-16 13:02 ` Kirill A. Shutemov
2008-09-16 13:31 ` Adrian Bunk
2008-09-16 14:10 ` Ulrich Drepper
2008-09-16 14:43 ` Kirill A. Shutemov
2008-09-16 16:09 ` Adrian Bunk
2008-09-17 9:32 ` Kirill A. Shutemov
2008-09-17 10:04 ` Kirill A. Shutemov
2008-09-17 10:12 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080916125802.GA15951@cs181140183.pp.htv.fi \
--to=bunk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=drepper@redhat.com \
--cc=dwmw2@infradead.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®