From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Greg K-H <greg@kroah.com>, "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH]sysfs: Don't emit a warning when sysfs_rename_link() fails.
Date: Wed, 17 Sep 2008 13:08:05 +0200 [thread overview]
Message-ID: <20080917130805.6260ba9c@gondolin.boeblingen.de.ibm.com> (raw)
Hi Greg, hi Eric,
the recent sysfs tagged directory changes switched device_rename() to
sysfs_rename_link() - which is a good thing but AFAICS re-introduces
the scary warnings when a netdevice is renamed to something that
already exists (which I tried to fix with
36ce6dad6e3cb3f050ed41e0beac0070d2062b25).
The following patch switches sysfs_rename_link() to non-warning symlink
creation again. It is on top of the current driver core series.
sysfs: Don't emit a warning when sysfs_rename_link() fails.
From: Cornelia Huck <cornelia.huck@de.ibm.com>
sysfs_rename_link() will be printing a scary looking warning
if a link of the same name already exists. Callers of
device_rename() don't want to see this warning since they
already handle the failure themselves, so let's use the not
warning variant of sysfs_do_create_link().
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
fs/sysfs/symlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/fs/sysfs/symlink.c
===================================================================
--- linux-2.6.orig/fs/sysfs/symlink.c
+++ linux-2.6/fs/sysfs/symlink.c
@@ -135,7 +135,7 @@ int sysfs_rename_link(struct kobject *ko
const char *old, const char *new)
{
sysfs_delete_link(kobj, targ, old);
- return sysfs_create_link(kobj, targ, new);
+ return sysfs_do_create_link(kobj, targ, new, 0);
}
static int sysfs_get_target_path(struct sysfs_dirent *parent_sd,
next reply other threads:[~2008-09-17 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 11:08 Cornelia Huck [this message]
2008-09-17 18:55 ` Eric W. Biederman
2008-09-18 7:07 ` Cornelia Huck
2008-09-18 10:00 ` Eric W. Biederman
2008-09-18 10:50 ` Cornelia Huck
2008-09-18 11:37 ` Eric W. Biederman
2008-09-18 12:28 ` [PATCH] sysfs: Remove sysfs_do_create_link() Cornelia Huck
2008-10-07 4:19 ` Greg KH
2008-10-07 7:23 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080917130805.6260ba9c@gondolin.boeblingen.de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®