From: ebiederm@xmission.com (Eric W. Biederman)
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Greg K-H <greg@kroah.com>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]sysfs: Don't emit a warning when sysfs_rename_link() fails.
Date: Thu, 18 Sep 2008 04:37:34 -0700 [thread overview]
Message-ID: <m1y71pvg5d.fsf@frodo.ebiederm.org> (raw)
In-Reply-To: <20080918125056.03c404e8@gondolin.boeblingen.de.ibm.com> (Cornelia Huck's message of "Thu, 18 Sep 2008 12:50:56 +0200")
Cornelia Huck <cornelia.huck@de.ibm.com> writes:
> On Thu, 18 Sep 2008 03:00:31 -0700,
> ebiederm@xmission.com (Eric W. Biederman) wrote:
>
>> In the dev_change_name we either do dev_alloc_name
>> which generates a unique device name or __dev_get_by_name
>> which looks to see if we are already using that name.
>
> Duh, I overlooked that, sorry about the noise.
No problem.
> (OTOH, we should get of sysfs_do_create_link() then, since it's an
> unneed indirection).
No objection from me.
Eric
next prev parent reply other threads:[~2008-09-18 11:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 11:08 Cornelia Huck
2008-09-17 18:55 ` Eric W. Biederman
2008-09-18 7:07 ` Cornelia Huck
2008-09-18 10:00 ` Eric W. Biederman
2008-09-18 10:50 ` Cornelia Huck
2008-09-18 11:37 ` Eric W. Biederman [this message]
2008-09-18 12:28 ` [PATCH] sysfs: Remove sysfs_do_create_link() Cornelia Huck
2008-10-07 4:19 ` Greg KH
2008-10-07 7:23 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1y71pvg5d.fsf@frodo.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=cornelia.huck@de.ibm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome