From: Lin Tan <tammy000@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH git latest] drivers/scsi: fixing wrong comment before new_buffer_tape()
Date: Thu, 25 Sep 2008 12:49:48 -0500 [thread overview]
Message-ID: <20080925174948.GA14180@carmen.cs.uiuc.edu> (raw)
(I would wish to be personally CC'ed the answers/comments posted to the list in response to my posting.)
---
Removing the wrong comment.
The lock is needed before calling new_tape_buffer(), at least in some cases.
So the comment above new_tape_buffer() is inconsistent with the code and
may mislead developers.
I simply removed the wrong comment, as I am not sure if the lock is required
in all situations. If so, we should add "Caller must hold os_scsi_tapes_lock".
Signed-off-by: Lin Tan <tammy000@gmail.com>
---
--- a/drivers/scsi/osst.c 2008-09-25 11:53:09.000000000 -0500
+++ b/drivers/scsi/osst.c 2008-09-25 11:59:46.000000000 -0500
@@ -5209,7 +5209,7 @@
\f
/* Memory handling routines */
-/* Try to allocate a new tape buffer skeleton. Caller must not hold os_scsi_tapes_lock */
+/* Try to allocate a new tape buffer skeleton. */
static struct osst_buffer * new_tape_buffer( int from_initialization, int need_dma, int max_sg )
{
int i;
next reply other threads:[~2008-09-25 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 17:49 Lin Tan [this message]
2008-09-26 10:13 ` Alan Cox
2008-09-26 16:05 ` Tammy
2008-09-26 16:09 ` Alan Cox
2008-09-26 16:20 ` James Bottomley
2008-09-26 17:06 ` Lin Tan
2008-09-26 19:55 ` Kai Makisara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080925174948.GA14180@carmen.cs.uiuc.edu \
--to=tammy000@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®