From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Lin Tan <tammy000@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH git latest] drivers/scsi: fixing wrong comment before new_buffer_tape()
Date: Fri, 26 Sep 2008 11:13:00 +0100 [thread overview]
Message-ID: <20080926111300.1dd34009@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20080925174948.GA14180@carmen.cs.uiuc.edu>
On Thu, 25 Sep 2008 12:49:48 -0500
Lin Tan <tammy000@gmail.com> wrote:
> (I would wish to be personally CC'ed the answers/comments posted to the list in response to my posting.)
>
> ---
>
> Removing the wrong comment.
> The lock is needed before calling new_tape_buffer(), at least in some cases.
> So the comment above new_tape_buffer() is inconsistent with the code and
> may mislead developers.
>
> I simply removed the wrong comment, as I am not sure if the lock is required
> in all situations. If so, we should add "Caller must hold os_scsi_tapes_lock".
>
> Signed-off-by: Lin Tan <tammy000@gmail.com>
Looks true to me for the current versions of the code. In fact it is only
ever called from the initialisation function that I can see so chunks of
the code could simply go away as well as bits of the comment. Ditto the
one in drivers/scsi/st.c
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2008-09-26 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 17:49 Lin Tan
2008-09-26 10:13 ` Alan Cox [this message]
2008-09-26 16:05 ` Tammy
2008-09-26 16:09 ` Alan Cox
2008-09-26 16:20 ` James Bottomley
2008-09-26 17:06 ` Lin Tan
2008-09-26 19:55 ` Kai Makisara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080926111300.1dd34009@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tammy000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®