From: Francois Romieu <romieu@fr.zoreil.com>
To: Lin Tan <tammy000@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH git latest] drivers/net: fixing a datarace related to update_stats()
Date: Sat, 27 Sep 2008 23:44:24 +0200 [thread overview]
Message-ID: <20080927214424.GA12865@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20080926023322.GA16514@carmen.cs.uiuc.edu>
(Please Cc: netdev@vger.kernel.org)
Lin Tan <tammy000@gmail.com> :
[drivers/net/pcmcia/3c589_cs.c race]
> As indicated by the following comment, a lock must be held before calling
> function update_stats(). This rule is followed in some cases, but not in
> others. For example, the lock is held when the function is called in function
> el3_get_stats(), but the lock is NOT held when called in el3_close(). It can
> cause potential data races.
I would not bet that the irq handler does not race with el3_close()
in the first place. Could you dig it ?
--
Ueimor
next prev parent reply other threads:[~2008-09-27 21:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 2:33 Lin Tan
2008-09-27 21:44 ` Francois Romieu [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-22 14:58 [PATCH] pcmcia: Fix broken abuse of dev->driver_data Alan Cox
2008-09-22 21:56 ` Dominik Brodowski
2008-09-22 22:12 ` Alan Cox
2008-09-22 22:26 ` Dominik Brodowski
2008-09-22 23:15 ` Alan Cox
2008-09-26 13:29 ` [PATCH git latest] drivers/net: fixing a datarace related to update_stats() Komuro
2008-09-26 16:06 ` Tammy
2008-09-26 17:31 ` Lin Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080927214424.GA12865@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tammy000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®