From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: torvalds@osdl.org, linux-pcmcia@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pcmcia: Fix broken abuse of dev->driver_data
Date: Tue, 23 Sep 2008 00:15:34 +0100 [thread overview]
Message-ID: <20080923001534.13031535@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20080922222655.GA3792@isilmar.linta.de>
> *gnah* already applied upstream, including the comment implying that PCMCIA
> driver's making use of driver_data were correct, while they were not. At
> least the trailing whitespace didn't get merged.
It was correct - dev->private_data for struct device is driver stuff, and
as the same drivers are used for pcmcia and non pcmcia its a bit hard to
argue otherwise.
Anyway tis finally sorted (and boy was it fun to pin down)
Alan
next prev parent reply other threads:[~2008-09-22 23:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 14:58 Alan Cox
2008-09-22 21:56 ` Dominik Brodowski
2008-09-22 22:12 ` Alan Cox
2008-09-22 22:26 ` Dominik Brodowski
2008-09-22 23:15 ` Alan Cox [this message]
2008-09-23 1:31 ` Komuro
2008-09-26 13:29 ` [PATCH git latest] drivers/net: fixing a datarace related to update_stats() Komuro
2008-09-26 16:06 ` Tammy
2008-09-26 17:31 ` Lin Tan
2008-11-01 2:07 ` [BUG REPORT!!!] [PATCH 19/49] pcmcia: remove remaining in-kernel pcmcia_get_configuration_info() users Komuro
2008-11-02 8:46 ` Komuro
2008-11-02 9:17 ` Dominik Brodowski
2008-11-02 10:33 ` Komuro
2008-11-02 12:04 ` Dominik Brodowski
2008-10-06 12:18 ` [PATCH 03/19] pcmcia: Whine harder about use of EXCLUSIVE Komuro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923001534.13031535@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux@dominikbrodowski.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®