mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] x86: mtrr_cleanup update command line
Date: Tue, 30 Sep 2008 16:57:39 -0700	[thread overview]
Message-ID: <20080930165739.7847be37.rdunlap@xenotime.net> (raw)
In-Reply-To: <1222817380-29481-1-git-send-email-yhlu.kernel@gmail.com>

On Tue, 30 Sep 2008 16:29:38 -0700 Yinghai Lu wrote:

> change enable_mtrr_cleanup to mtrr-cleanup, disable_mtrr_cleanup to nomtrr-cleanup.
> 
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> 
> ---
>  Documentation/kernel-parameters.txt |    4 ++--
>  arch/x86/Kconfig                    |    2 +-
>  arch/x86/kernel/cpu/mtrr/main.c     |    4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> Index: linux-2.6/Documentation/kernel-parameters.txt
> ===================================================================
> --- linux-2.6.orig/Documentation/kernel-parameters.txt
> +++ linux-2.6/Documentation/kernel-parameters.txt
> @@ -614,8 +614,8 @@ and is between 256 and 4096 characters.
>  			See drivers/char/README.epca and
>  			Documentation/digiepca.txt.
>  
> -	disable_mtrr_cleanup [X86]
> -	enable_mtrr_cleanup [X86]
> +	nomtrr-cleanup [X86]
> +	mtrr-cleanup [X86]
>  			The kernel tries to adjust MTRR layout from continuous
>  			to discrete, to make X server driver able to add WB
>  			entry later. This parameter enables/disables that.

Looks like Documentation/kernel-parameters.txt needs a comment that says that
entries are supposed to be listed in alphabetical order, not grouped by <subject>.
Please don't add them like this.

E.g., the "apic" entries are not grouped together and these mtrr entries should
not be grouped together unless they all begin with "mtrr", which is an option here:
they could be renamed to "mtrr-cleanup" and "mtrr-nocleanup".
And "disable_mtrr_trim" could be renamed to "mtrr-notrim".


> Index: linux-2.6/arch/x86/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/x86/Kconfig
> +++ linux-2.6/arch/x86/Kconfig
> @@ -1250,7 +1250,7 @@ config MTRR_SANITIZER
>  	  Convert MTRR layout from continuous to discrete, so X drivers can
>  	  add writeback entries.
>  
> -	  Can be disabled with disable_mtrr_cleanup on the kernel command line.
> +	  Can be disabled with nomtrr-cleanup on the kernel command line.
>  	  The largest mtrr entry size for a continous block can be set with
>  	  mtrr_chunk_size.
>  
> Index: linux-2.6/arch/x86/kernel/cpu/mtrr/main.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/cpu/mtrr/main.c
> +++ linux-2.6/arch/x86/kernel/cpu/mtrr/main.c
> @@ -826,7 +826,7 @@ static int __init disable_mtrr_cleanup_s
>  		enable_mtrr_cleanup = 0;
>  	return 0;
>  }
> -early_param("disable_mtrr_cleanup", disable_mtrr_cleanup_setup);
> +early_param("nomtrr-cleanup", disable_mtrr_cleanup_setup);
>  
>  static int __init enable_mtrr_cleanup_setup(char *str)
>  {
> @@ -834,7 +834,7 @@ static int __init enable_mtrr_cleanup_se
>  		enable_mtrr_cleanup = 1;
>  	return 0;
>  }
> -early_param("enable_mtrr_cleanup", enable_mtrr_cleanup_setup);
> +early_param("mtrr-cleanup", enable_mtrr_cleanup_setup);
>  
>  static int __init mtrr_cleanup_debug_setup(char *str)
>  {


---
~Randy

  parent reply	other threads:[~2008-09-30 23:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-30 23:29 Yinghai Lu
2008-09-30 23:29 ` [PATCH 2/3] x86: doc mtrr-cleanup-debug Yinghai Lu
2008-09-30 23:29 ` [PATCH 3/3] x86: change MTRR_SANITIZER to def_bool y Yinghai Lu
2008-10-01  6:36   ` Ingo Molnar
2008-10-01  6:46     ` Yinghai Lu
2008-10-01  7:24       ` J.A. Magallón
2008-09-30 23:57 ` Randy Dunlap [this message]
2008-09-30 23:41   ` [PATCH 1/3] x86: mtrr_cleanup update command line H. Peter Anvin
2008-09-30 23:52     ` Yinghai Lu
2008-09-30 23:59       ` Yinghai Lu
2008-10-01  0:35         ` Randy Dunlap
2008-10-01  0:41         ` Randy Dunlap
2008-10-01  0:07     ` Randy Dunlap
2008-10-09  0:07   ` Randy Dunlap
2008-10-09  1:28     ` Yinghai Lu
2008-10-09 17:20       ` Randy Dunlap
2008-10-09 18:08         ` Yinghai Lu
2008-10-09 18:43           ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080930165739.7847be37.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®