mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	Arjan van de Veen <arjan@infradead.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Jon Masters <jonathan@jonmasters.org>,
	Sven Dietrich <sdietrich@suse.de>
Subject: [RFC patch 4/5] genirq: add a helper to check whether the irq thread should run
Date: Wed, 01 Oct 2008 23:02:27 -0000	[thread overview]
Message-ID: <20081001223302.111345767@linutronix.de> (raw)
In-Reply-To: <20081001223213.078984344@linutronix.de>

[-- Attachment #1: genirq-add-irq-trigger-check.patch --]
[-- Type: text/plain, Size: 1519 bytes --]

The helper allows threaded irq handlers to determine whether another
interrupt arrived or not while the thread is running.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Ingo Molnar <mingo@elte.hu>
---
 include/linux/interrupt.h |    5 +++++
 kernel/irq/manage.c       |    2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

Index: linux-2.6-tip/include/linux/interrupt.h
===================================================================
--- linux-2.6-tip.orig/include/linux/interrupt.h
+++ linux-2.6-tip/include/linux/interrupt.h
@@ -109,6 +109,11 @@ extern int __must_check devm_request_irq
 			    const char *devname, void *dev_id);
 extern void devm_free_irq(struct device *dev, unsigned int irq, void *dev_id);
 
+static inline int irq_thread_should_run(struct irqaction *action)
+{
+	return test_and_clear_bit(IRQF_RUNTHREAD, &action->flags);
+}
+
 /*
  * On lockdep we dont want to enable hardirqs in hardirq
  * context. Use local_irq_enable_in_hardirq() to annotate
Index: linux-2.6-tip/kernel/irq/manage.c
===================================================================
--- linux-2.6-tip.orig/kernel/irq/manage.c
+++ linux-2.6-tip/kernel/irq/manage.c
@@ -341,7 +341,7 @@ static int irq_thread(void *data)
 	set_current_state(TASK_INTERRUPTIBLE);
 
 	while (!kthread_should_stop()) {
-		if (!test_and_clear_bit(IRQF_RUNTHREAD, &action->flags)) {
+		if (!irq_thread_should_run(action)) {
 			schedule();
 			/* Avoid running the handler on stop */
 			if (kthread_should_stop())



  parent reply	other threads:[~2008-10-01 23:03 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-01 23:02 [RFC patch 0/5] genirq: add infrastructure for threaded interrupt handlers Thomas Gleixner
2008-10-01 23:02 ` [RFC patch 1/5] genirq: make irqreturn_t an enum Thomas Gleixner
2008-10-01 23:02 ` [RFC patch 2/5] genirq: add a quick check handler Thomas Gleixner
2008-10-02  0:47   ` Jon Masters
2008-10-02  5:09     ` Steven Rostedt
2008-10-02 10:51       ` Jon Masters
2008-10-02 22:06         ` Greg KH
2008-10-02  4:52   ` Steven Rostedt
2008-10-03  8:29   ` Christoph Hellwig
2008-10-03 10:37     ` Thomas Gleixner
2008-10-01 23:02 ` [RFC patch 3/5] genirq: add threaded interrupt handler support Thomas Gleixner
2008-10-02  5:01   ` Steven Rostedt
2008-10-01 23:02 ` Thomas Gleixner [this message]
2008-10-01 23:02 ` [RFC patch 5/5] genirq: make irq threading robust Thomas Gleixner
2008-10-02  0:52   ` Jon Masters
2008-10-02  5:20     ` Steven Rostedt
2008-10-01 23:23 ` [RFC patch 0/5] genirq: add infrastructure for threaded interrupt handlers Andrew Morton
2008-10-01 23:29   ` Arjan van de Ven
2008-10-01 23:40     ` Andrew Morton
2008-10-01 23:58       ` Thomas Gleixner
2008-10-02  0:40 ` Jon Masters
2008-10-02 22:07   ` Greg KH
2008-10-08 22:18     ` Ingo Oeser
2008-10-02  1:53 ` Daniel Walker
2008-10-02 15:02   ` Steven Rostedt
2008-10-02 15:48     ` Daniel Walker
2008-10-02 18:42       ` Thomas Gleixner
2008-10-02 19:04         ` Daniel Walker
2008-10-02 19:23           ` Steven Rostedt
2008-10-02 19:28           ` Ingo Molnar
2008-10-02 20:09             ` Daniel Walker
2008-10-02 20:14               ` Steven Rostedt
2008-10-02 20:48                 ` Daniel Walker
2008-10-02 21:05                   ` Steven Rostedt
2008-10-02 21:30                     ` Daniel Walker
2008-10-02 22:28                       ` Steven Rostedt
2008-10-02 23:24                         ` Daniel Walker
2008-10-03  0:26                           ` Thomas Gleixner
2008-10-03 14:44                             ` Daniel Walker
2008-10-02 14:46 ` Andi Kleen
2008-10-02 21:31   ` Greg KH
2008-10-02 22:33     ` Arjan van de Ven
2008-10-03  3:25       ` Andi Kleen
2008-10-03  3:48         ` Arjan van de Ven
2008-10-03  4:35           ` Andi Kleen
2008-10-03  3:23     ` Andi Kleen
2008-10-21  1:32 ` [RFC patch] genirq threading for ehci, ohci and uhci USB hosts Sven-Thorsten Dietrich
2008-10-21  2:07   ` Jonathan Woithe
2008-10-21 10:29     ` [RFC patch] genirq threading (v2) for ehci, ohci and uhci USB hosts and ohci1394 Sven-Thorsten Dietrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081001223302.111345767@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=benh@kernel.crashing.org \
    --cc=jonathan@jonmasters.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=sdietrich@suse.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome