From: Ingo Molnar <mingo@elte.hu>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mathieu.desnoyers@polymtl.ca, laijs@cn.fujitsu.com,
manfred@colorfullife.com, dipankar@in.ibm.com, niv@us.ibm.com,
dvhltc@us.ibm.com, josht@linux.vnet.ibm.com
Subject: Re: [PATCH,RFC] RCU-based detection of stalled CPUs for Classic RCU
Date: Thu, 2 Oct 2008 10:07:26 +0200 [thread overview]
Message-ID: <20081002080726.GB17695@elte.hu> (raw)
In-Reply-To: <20081002003628.GA7877@linux.vnet.ibm.com>
* Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
> Hello!
>
> This patch adds stalled-CPU detection to Classic RCU. This capability
> is enabled by a new config variable CONFIG_RCU_CPU_STALL_DETECTOR,
> which defaults disabled. This is a debugging feature, not something
> that non-kernel-hackers would be expected to care about. This feature
> can detect looping CPUs in !PREEMPT builds and looping CPUs with
> preemption disabled in PREEMPT builds. This is essentially a port of
> this functionality from the treercu patch.
>
> One current shortcoming: on some systems, stalls are detected during
> early boot, when we normally would not care about them. My thought is
> to add a call from late initialization to suppress stall detection
> until the system is well along its way to being booted, but thought I
> should check to see if there might already be something for this
> purpose.
could you be a bit more specific, why do those warnings show up and why
dont we care about them? There are things like networking that
occasionally do an rcu_sync() and a stall could mean a bootup hang.
> (Currently against 2.6.27-rc8, FYI.)
>
> Thoughts?
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
i think this is a very good idea in general - often the question comes
up whether a hang seen in the RCU code is indeed caused by RCU or other
factors. Could you perhaps rebase it against tip/core/rcu ? [or
tip/master for convenience]
Ingo
next prev parent reply other threads:[~2008-10-02 8:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 0:36 Paul E. McKenney
2008-10-02 8:07 ` Ingo Molnar [this message]
2008-10-02 14:05 ` Paul E. McKenney
2008-10-02 15:10 ` Mathieu Desnoyers
2008-10-02 17:43 ` Paul E. McKenney
2008-10-02 18:51 ` [PATCH,RFC] RCU-based detection of stalled CPUs for Classic RCU (LTTng support) Mathieu Desnoyers
2008-10-02 22:55 ` Paul E. McKenney
2008-10-02 23:06 ` [PATCH tip/master] RCU-based detection of stalled CPUs for Classic RCU Paul E. McKenney
2008-10-03 4:41 ` Mathieu Desnoyers
2008-10-03 5:02 ` Paul E. McKenney
2008-10-03 8:39 ` Ingo Molnar
2008-10-03 8:42 ` [PATCH] rcu: RCU-based detection of stalled CPUs for Classic RCU, fix Ingo Molnar
2008-10-03 15:14 ` Paul E. McKenney
2008-10-03 15:13 ` [PATCH tip/master] RCU-based detection of stalled CPUs for Classic RCU Paul E. McKenney
2008-10-02 17:39 ` [PATCH,RFC] " Paul E. McKenney
2008-10-03 10:12 ` Lai Jiangshan
2008-10-03 15:12 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081002080726.GB17695@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=josht@linux.vnet.ibm.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®