From: Ingo Molnar <mingo@elte.hu>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mathieu.desnoyers@polymtl.ca,
akpm@linux-foundation.org, laijs@cn.fujitsu.com,
manfred@colorfullife.com, dipankar@in.ibm.com, niv@us.ibm.com,
dvhltc@us.ibm.com, josht@linux.vnet.ibm.com,
ltt-dev@lists.casi.polymtl.ca
Subject: Re: [PATCH tip/master] RCU-based detection of stalled CPUs for Classic RCU
Date: Fri, 3 Oct 2008 10:39:47 +0200 [thread overview]
Message-ID: <20081003083947.GB7636@elte.hu> (raw)
In-Reply-To: <20081002230639.GA7522@linux.vnet.ibm.com>
* Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
> Hello!
>
> This patch adds stalled-CPU detection to Classic RCU. This capability
> is enabled by a new config variable CONFIG_RCU_CPU_STALL_DETECTOR,
> which defaults disabled. This is a debugging feature to detect
> infinite loops in kernel code, not something that non-kernel-hackers
> would be expected to care about. This feature can detect looping CPUs
> in !PREEMPT builds and looping CPUs with preemption disabled in
> PREEMPT builds. This is essentially a port of this functionality from
> the treercu patch, replacing the stall debug patch that is already in
> tip/core/rcu (commit 67182ae1c4).
>
> The changes from the patch in tip/core/rcu include making the config
> variable name match that in treercu, changing from seconds to jiffies
> to avoid spurious warnings, and printing a boot message when this
> feature is enabled.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
applied to tip/core/rcu, thanks Paul!
i tidied up two tiny details noticed by scripts/checkpatch.pl:
> +#define RCU_SECONDS_TILL_STALL_CHECK 3 * HZ /* for rcp->jiffies_stall */
> +#define RCU_SECONDS_TILL_STALL_RECHECK 30 * HZ /* for rcp->jiffies_stall */
adding paranthesis around the expression.
> + if (cpu_isset(smp_processor_id(), rcp->cpumask) && delta >= 0) {
> +
and have removed the two tailing tabs from this line.
Ingo
next prev parent reply other threads:[~2008-10-03 8:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 0:36 [PATCH,RFC] " Paul E. McKenney
2008-10-02 8:07 ` Ingo Molnar
2008-10-02 14:05 ` Paul E. McKenney
2008-10-02 15:10 ` Mathieu Desnoyers
2008-10-02 17:43 ` Paul E. McKenney
2008-10-02 18:51 ` [PATCH,RFC] RCU-based detection of stalled CPUs for Classic RCU (LTTng support) Mathieu Desnoyers
2008-10-02 22:55 ` Paul E. McKenney
2008-10-02 23:06 ` [PATCH tip/master] RCU-based detection of stalled CPUs for Classic RCU Paul E. McKenney
2008-10-03 4:41 ` Mathieu Desnoyers
2008-10-03 5:02 ` Paul E. McKenney
2008-10-03 8:39 ` Ingo Molnar [this message]
2008-10-03 8:42 ` [PATCH] rcu: RCU-based detection of stalled CPUs for Classic RCU, fix Ingo Molnar
2008-10-03 15:14 ` Paul E. McKenney
2008-10-03 15:13 ` [PATCH tip/master] RCU-based detection of stalled CPUs for Classic RCU Paul E. McKenney
2008-10-02 17:39 ` [PATCH,RFC] " Paul E. McKenney
2008-10-03 10:12 ` Lai Jiangshan
2008-10-03 15:12 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003083947.GB7636@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=josht@linux.vnet.ibm.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@lists.casi.polymtl.ca \
--cc=manfred@colorfullife.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®