mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	tglx@linutronix.de, arjan@linux.intel.com, airlied@gmail.com,
	davem@davemloft.net, jeff@garzik.org
Subject: [PATCH 2.6.27-rc8 0/6] e1000e mutex protection
Date: Thu, 02 Oct 2008 16:33:14 -0700	[thread overview]
Message-ID: <20081002233314.12556.49143.stgit@jbrandeb-bw.jf.intel.com> (raw)

This series of patches fixes several bugs found by putting a
mutex inside e1000_acquire_swfw_flag, and then the patch from
Thomas actually adds this mutex to help find any further bugs.

Like Jesse Barnes said, "totally up to you (obviously) whether we
stuff this into 2.6.27 or hold on it until 2.6.28."

Linus, since you mentioned this exact same issue that Thomas (and
Dave Airlie) spotted I figured I should just send these.
Testing will continue over the next couple of days and I'll let
you know immediately if we find something.

The patches are pretty straight forward and each one fixed a
separate bug we found using the mutex patch.  It is possible that
these fix the actual corruption issue but we haven't verified
that yet.

---

Jesse Brandeburg (5):
      e1000e: update version from k4 to k6
      e1000e: drop stats lock
      e1000e: remove phy read from inside spinlock
      e1000e: do not ever sleep in interrupt context
      e1000e: reset swflag after resetting hardware

Thomas Gleixner (1):
      e1000e: debug contention on NVM SWFLAG


 drivers/net/e1000e/e1000.h   |    3 +-
 drivers/net/e1000e/ethtool.c |    6 +++-
 drivers/net/e1000e/ich8lan.c |   20 +++++++++++++
 drivers/net/e1000e/netdev.c  |   64 +++++++++++++++++++-----------------------
 4 files changed, 56 insertions(+), 37 deletions(-)

-- 
Jesse Brandeburg

             reply	other threads:[~2008-10-02 23:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02 23:33 Jesse Brandeburg [this message]
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 1/6] e1000e: reset swflag after resetting hardware Jesse Brandeburg
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 2/6] e1000e: do not ever sleep in interrupt context Jesse Brandeburg
2008-10-03  0:36   ` Thomas Gleixner
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 3/6] e1000e: remove phy read from inside spinlock Jesse Brandeburg
2008-10-03  0:37   ` Thomas Gleixner
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 4/6] e1000e: drop stats lock Jesse Brandeburg
2008-10-03  0:38   ` Thomas Gleixner
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 5/6] e1000e: debug contention on NVM SWFLAG Jesse Brandeburg
2008-10-03 11:47   ` Jiri Kosina
2008-10-03 15:16     ` Linus Torvalds
2008-10-03 15:39       ` Jiri Kosina
2008-10-03 19:38         ` Thomas Gleixner
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 6/6] e1000e: update version from k4 to k6 Jesse Brandeburg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081002233314.12556.49143.stgit@jbrandeb-bw.jf.intel.com \
    --to=jesse.brandeburg@intel.com \
    --cc=airlied@gmail.com \
    --cc=arjan@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®