mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	tglx@linutronix.de, arjan@linux.intel.com, airlied@gmail.com,
	davem@davemloft.net, jeff@garzik.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: [PATCH 2.6.27-rc8 1/6] e1000e: reset swflag after resetting hardware
Date: Thu, 02 Oct 2008 16:33:20 -0700	[thread overview]
Message-ID: <20081002233319.12556.31820.stgit@jbrandeb-bw.jf.intel.com> (raw)
In-Reply-To: <20081002233314.12556.49143.stgit@jbrandeb-bw.jf.intel.com>

in the process of debugging things, noticed that the swflag is not reset
by the driver after reset, and the swflag is probably not reset unless
management firmware clears it after 100ms.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---

 drivers/net/e1000e/ich8lan.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/e1000e/ich8lan.c b/drivers/net/e1000e/ich8lan.c
index d8efba8..f4b6744 100644
--- a/drivers/net/e1000e/ich8lan.c
+++ b/drivers/net/e1000e/ich8lan.c
@@ -1778,6 +1778,9 @@ static s32 e1000_reset_hw_ich8lan(struct e1000_hw *hw)
 	ew32(CTRL, (ctrl | E1000_CTRL_RST));
 	msleep(20);
 
+	/* release the swflag because it is not reset by hardware reset */
+	e1000_release_swflag_ich8lan(hw);
+
 	ret_val = e1000e_get_auto_rd_done(hw);
 	if (ret_val) {
 		/*


  reply	other threads:[~2008-10-02 23:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02 23:33 [PATCH 2.6.27-rc8 0/6] e1000e mutex protection Jesse Brandeburg
2008-10-02 23:33 ` Jesse Brandeburg [this message]
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 2/6] e1000e: do not ever sleep in interrupt context Jesse Brandeburg
2008-10-03  0:36   ` Thomas Gleixner
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 3/6] e1000e: remove phy read from inside spinlock Jesse Brandeburg
2008-10-03  0:37   ` Thomas Gleixner
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 4/6] e1000e: drop stats lock Jesse Brandeburg
2008-10-03  0:38   ` Thomas Gleixner
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 5/6] e1000e: debug contention on NVM SWFLAG Jesse Brandeburg
2008-10-03 11:47   ` Jiri Kosina
2008-10-03 15:16     ` Linus Torvalds
2008-10-03 15:39       ` Jiri Kosina
2008-10-03 19:38         ` Thomas Gleixner
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 6/6] e1000e: update version from k4 to k6 Jesse Brandeburg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081002233319.12556.31820.stgit@jbrandeb-bw.jf.intel.com \
    --to=jesse.brandeburg@intel.com \
    --cc=airlied@gmail.com \
    --cc=arjan@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®