From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [regression] Latest git has WARN_ON storm with e1000e driver
Date: Fri, 3 Oct 2008 17:20:53 +0200 [thread overview]
Message-ID: <200810031720.53923.borntraeger@de.ibm.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0810030746430.3230@nehalem.linux-foundation.org>
Am Freitag, 3. Oktober 2008 schrieben Sie:
> Which spinlock is it? It sure shouldn't be anything in the generic drievr
> layer: __driver_attach takes a lock, but it's a semaphore (dev->sem), not
> a spinlock. In fact, al lot of drivers will sleep or do allocations, so if
> the driver layer were to call the probe function with a spinlock held,
> things would be really broken.
>
> The callchain has "spin_lock_irqsave" in it, but that's stale stack data.
Very good point indeed. Seems my analysis was wrong. I made a short test and
preempt_count() returns 1 when the WARN_ON triggers. So its either a spinlock
or something else that increased my preempt_count.
next prev parent reply other threads:[~2008-10-03 15:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 8:41 Christian Borntraeger
2008-10-03 14:52 ` Linus Torvalds
2008-10-03 15:20 ` Christian Borntraeger [this message]
2008-10-03 15:36 ` Linus Torvalds
2008-10-03 15:50 ` Christian Borntraeger
2008-10-03 15:55 ` Christian Borntraeger
2008-10-03 16:05 ` Linus Torvalds
2008-10-03 16:23 ` Linus Torvalds
2008-10-03 16:25 ` Brandeburg, Jesse
2008-10-03 16:36 ` Linus Torvalds
2008-10-03 19:41 ` Thomas Gleixner
2008-10-03 16:25 ` Christian Borntraeger
2008-10-03 15:08 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810031720.53923.borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®