From: Linus Torvalds <torvalds@linux-foundation.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [regression] Latest git has WARN_ON storm with e1000e driver
Date: Fri, 3 Oct 2008 09:05:27 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0810030901170.3185@nehalem.linux-foundation.org> (raw)
In-Reply-To: <200810031755.55931.borntraeger@de.ibm.com>
On Fri, 3 Oct 2008, Christian Borntraeger wrote:
>
> kernel_init does lock_kernel (which does preempt_disable).
> The kernel_unlock is done in init_post. As far as I can see, this happens
> after the driver init calls.
Yes. I just came to the same conclusion: preempt_count is 1 already in
do_one_initcall().
So this whole bug is actually because that debug test is just _broken_. It
shouldn't be WARN_ON(preempt_count()), it should be 'might_sleep()', which
does it right.
The right thing to check is "in_atomic() || irqs_disabled()".
Duh. That was wasted effort for a buggy test.
Linus
next prev parent reply other threads:[~2008-10-03 16:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 8:41 Christian Borntraeger
2008-10-03 14:52 ` Linus Torvalds
2008-10-03 15:20 ` Christian Borntraeger
2008-10-03 15:36 ` Linus Torvalds
2008-10-03 15:50 ` Christian Borntraeger
2008-10-03 15:55 ` Christian Borntraeger
2008-10-03 16:05 ` Linus Torvalds [this message]
2008-10-03 16:23 ` Linus Torvalds
2008-10-03 16:25 ` Brandeburg, Jesse
2008-10-03 16:36 ` Linus Torvalds
2008-10-03 19:41 ` Thomas Gleixner
2008-10-03 16:25 ` Christian Borntraeger
2008-10-03 15:08 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0810030901170.3185@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=borntraeger@de.ibm.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®