From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Julia Lawall <julia@diku.dk>
Cc: schwidefsky@de.ibm.com, linux390@de.ibm.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers/s390/cio/chsc_sch.c: Correct use of ! and &
Date: Mon, 6 Oct 2008 12:52:27 +0200 [thread overview]
Message-ID: <20081006105227.GA6303@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0810042205090.19286@ask.diku.dk>
On Sat, Oct 04, 2008 at 10:05:47PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> In commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337, a bug was fixed that
> involved converting !x & y to !(x & y). The code below shows the same
> pattern, and thus should perhaps be fixed in the same way. In particular,
> the result of !scsw_stctl(&request->irb.scsw) & SCSW_STCTL_STATUS_PEND is
> always just !scsw_stctl(&request->irb.scsw).
> [...]
> - if (!scsw_stctl(&request->irb.scsw) & SCSW_STCTL_STATUS_PEND)
> + if (!(scsw_stctl(&request->irb.scsw) & SCSW_STCTL_STATUS_PEND))
> return -EIO;
> backed_up = scsw_cstat(&request->irb.scsw) & SCHN_STAT_CHAIN_CHECK;
> request->irb.scsw.cmd.cstat &= ~SCHN_STAT_CHAIN_CHECK;
Nice finding. Thank you!
prev parent reply other threads:[~2008-10-06 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-04 20:05 Julia Lawall
2008-10-06 1:25 ` M. Asselstine
2008-10-06 10:52 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081006105227.GA6303@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®