* [PATCH] UV: cosmetic fix to interrupt handler definition
@ 2008-10-08 21:57 Cliff Wickman
2008-10-09 12:19 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Cliff Wickman @ 2008-10-08 21:57 UTC (permalink / raw)
To: linux-kernel; +Cc: mingo
From: Cliff Wickman <cpw@sgi.com>
The UV Broadcast Assist Unit (BAU) interrupt handler is erroneously
declared with a hardcoded vector 220 (that was used during testing).
It should be declared with the vector that is reserved for it.
The interrupt handler does not use the 220 that is pushed onto its
stack, so this error had no runtime effect.
Diffed against 2.6.27-rc8
Signed-off-by: Cliff Wickman <cpw@sgi.com>
---
arch/x86/kernel/entry_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: 081002.linus/arch/x86/kernel/entry_64.S
===================================================================
--- 081002.linus.orig/arch/x86/kernel/entry_64.S
+++ 081002.linus/arch/x86/kernel/entry_64.S
@@ -878,7 +878,7 @@ ENTRY(apic_timer_interrupt)
END(apic_timer_interrupt)
ENTRY(uv_bau_message_intr1)
- apicinterrupt 220,uv_bau_message_interrupt
+ apicinterrupt UV_BAU_MESSAGE,uv_bau_message_interrupt
END(uv_bau_message_intr1)
ENTRY(error_interrupt)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] UV: cosmetic fix to interrupt handler definition
2008-10-08 21:57 [PATCH] UV: cosmetic fix to interrupt handler definition Cliff Wickman
@ 2008-10-09 12:19 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-10-09 12:19 UTC (permalink / raw)
To: Cliff Wickman; +Cc: linux-kernel, Thomas Gleixner, H. Peter Anvin
* Cliff Wickman <cpw@sgi.com> wrote:
> From: Cliff Wickman <cpw@sgi.com>
>
> The UV Broadcast Assist Unit (BAU) interrupt handler is erroneously
> declared with a hardcoded vector 220 (that was used during testing).
> It should be declared with the vector that is reserved for it.
>
> The interrupt handler does not use the 220 that is pushed onto its
> stack, so this error had no runtime effect.
>
> Diffed against 2.6.27-rc8
>
> Signed-off-by: Cliff Wickman <cpw@sgi.com>
applied to tip/x86/uv, thanks Cliff!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-09 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-08 21:57 [PATCH] UV: cosmetic fix to interrupt handler definition Cliff Wickman
2008-10-09 12:19 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®