* [2.6 patch] export genphy_restart_aneg
@ 2008-10-13 17:19 Adrian Bunk
2008-10-13 18:04 ` Andy Fleming
2008-10-14 1:48 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Adrian Bunk @ 2008-10-13 17:19 UTC (permalink / raw)
To: Lennert Buytenhek, Andy Fleming, jgarzik
Cc: netdev, linux-kernel, linuxppc-dev
This patch fixes the following build error caused by
commit ed94493fb38a665cebcf750dfabe8a6dd13e136f
(mv643xx_eth: convert to phylib):
<-- snip -->
...
Building modules, stage 2.
MODPOST 1280 modules
ERROR: "genphy_restart_aneg" [drivers/net/mv643xx_eth.ko] undefined!
...
make[2]: *** [__modpost] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 1716274..f11e900 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -557,6 +557,7 @@ int genphy_restart_aneg(struct phy_device *phydev)
return ctl;
}
+EXPORT_SYMBOL(genphy_restart_aneg);
/**
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] export genphy_restart_aneg
2008-10-13 17:19 [2.6 patch] export genphy_restart_aneg Adrian Bunk
@ 2008-10-13 18:04 ` Andy Fleming
2008-10-13 18:52 ` David Miller
2008-10-14 1:48 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Andy Fleming @ 2008-10-13 18:04 UTC (permalink / raw)
To: Adrian Bunk
Cc: Lennert Buytenhek, jgarzik, netdev, linux-kernel, linuxppc-dev
On Oct 13, 2008, at 12:19, Adrian Bunk wrote:
> This patch fixes the following build error caused by
> commit ed94493fb38a665cebcf750dfabe8a6dd13e136f
> (mv643xx_eth: convert to phylib):
>
> <-- snip -->
>
> ...
> Building modules, stage 2.
> MODPOST 1280 modules
> ERROR: "genphy_restart_aneg" [drivers/net/mv643xx_eth.ko] undefined!
> ...
> make[2]: *** [__modpost] Error 1
>
> <-- snip -->
>
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Could you get genphy_setup_forced, too? It doesn't appear to be used,
but it's currently in include/linux/phy.h, and not static.
Alternatively, we could change genphy_setup_forced to be static. :)
Andy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] export genphy_restart_aneg
2008-10-13 18:04 ` Andy Fleming
@ 2008-10-13 18:52 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2008-10-13 18:52 UTC (permalink / raw)
To: afleming; +Cc: bunk, buytenh, jgarzik, netdev, linux-kernel, linuxppc-dev
From: Andy Fleming <afleming@freescale.com>
Date: Mon, 13 Oct 2008 13:04:30 -0500
>
> On Oct 13, 2008, at 12:19, Adrian Bunk wrote:
>
> > This patch fixes the following build error caused by
> > commit ed94493fb38a665cebcf750dfabe8a6dd13e136f
> > (mv643xx_eth: convert to phylib):
> >
> > <-- snip -->
> >
> > ...
> > Building modules, stage 2.
> > MODPOST 1280 modules
> > ERROR: "genphy_restart_aneg" [drivers/net/mv643xx_eth.ko] undefined!
> > ...
> > make[2]: *** [__modpost] Error 1
> >
> > <-- snip -->
> >
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
>
> Could you get genphy_setup_forced, too? It doesn't appear to be used, but it's currently in include/linux/phy.h, and not static.
When there is a use we can add the export.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] export genphy_restart_aneg
2008-10-13 17:19 [2.6 patch] export genphy_restart_aneg Adrian Bunk
2008-10-13 18:04 ` Andy Fleming
@ 2008-10-14 1:48 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2008-10-14 1:48 UTC (permalink / raw)
To: bunk; +Cc: buytenh, afleming, jgarzik, netdev, linux-kernel, linuxppc-dev
From: Adrian Bunk <bunk@kernel.org>
Date: Mon, 13 Oct 2008 20:19:00 +0300
> This patch fixes the following build error caused by
> commit ed94493fb38a665cebcf750dfabe8a6dd13e136f
> (mv643xx_eth: convert to phylib):
Applied, th anks Adrian.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-10-14 1:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-13 17:19 [2.6 patch] export genphy_restart_aneg Adrian Bunk
2008-10-13 18:04 ` Andy Fleming
2008-10-13 18:52 ` David Miller
2008-10-14 1:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®