From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: n0ano@n0ano.com
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
donald.d.dugger@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Enable console on PCI serial devices
Date: Fri, 17 Oct 2008 08:46:40 -0600 [thread overview]
Message-ID: <200810170846.41032.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <20081017141102.GG14490@xolotl.n0ano.com>
On Friday 17 October 2008 08:11:02 am n0ano@n0ano.com wrote:
> On Fri, Oct 17, 2008 at 10:28:58AM +0100, Alan Cox wrote:
> > Different discussion and different patches. We can get patches in for the
> > crystal frequency stuff and then debate the rest later
>
> In that case, here is the crystal frequency patch (typos fixed and
> proper sign off line).
I like this patch, except ...
> + "options" are the same as for ttyS, above. "clk"
> + is the crystal frequency which defaults to 115200
> + (typically the fastest baud rate supported by the
> + uart) but some hardware use different crystals.
this text is a little confusing. Since you multiply by 16 below, the
number specified by the user isn't really the crystal frequency, is it?
> + options = strchr(options, ',');
> + if (options) {
> + options++;
> + port->uartclk = simple_strtoul(options, NULL, 0) * 16;
> + }
next prev parent reply other threads:[~2008-10-17 14:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 22:31 donald.d.dugger
2008-10-14 22:39 ` Yinghai Lu
2008-10-14 23:30 ` n0ano
2008-10-15 9:13 ` Paul Bolle
2008-10-15 20:48 ` n0ano
2008-10-16 10:43 ` Paul Bolle
2008-10-16 16:23 ` Yinghai Lu
2008-10-16 17:12 ` n0ano
2008-10-16 18:19 ` Yinghai Lu
2008-10-16 18:25 ` n0ano
2008-10-16 18:30 ` Yinghai Lu
2008-10-16 18:57 ` n0ano
2008-10-17 2:45 ` n0ano
2008-10-17 3:32 ` Yinghai Lu
2008-10-17 16:05 ` n0ano
2008-10-17 17:01 ` Yinghai Lu
2008-10-14 22:53 ` Alan Cox
2008-10-14 23:04 ` n0ano
2008-10-16 23:16 ` Bjorn Helgaas
2008-10-17 2:39 ` n0ano
2008-10-17 9:28 ` Alan Cox
2008-10-17 14:11 ` n0ano
2008-10-17 14:46 ` Bjorn Helgaas [this message]
2008-10-17 15:36 ` n0ano
2008-10-17 16:39 ` Bjorn Helgaas
2008-10-17 17:06 ` n0ano
2008-10-20 16:44 ` Lennart Sorensen
2008-10-20 17:11 ` Bjorn Helgaas
2008-10-20 17:43 ` n0ano
2008-10-20 19:11 ` Bjorn Helgaas
2008-10-21 20:08 ` n0ano
2008-10-21 22:08 ` Bjorn Helgaas
2008-10-21 22:33 ` n0ano
2008-10-17 14:44 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810170846.41032.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=donald.d.dugger@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=n0ano@n0ano.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®