mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: n0ano@n0ano.com
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: n0ano@n0ano.com, Bjorn Helgaas <bjorn.helgaas@hp.com>,
	donald.d.dugger@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Enable console on PCI serial devices
Date: Fri, 17 Oct 2008 08:11:02 -0600	[thread overview]
Message-ID: <20081017141102.GG14490@xolotl.n0ano.com> (raw)
In-Reply-To: <20081017102858.1f1d77f7@lxorguk.ukuu.org.uk>

On Fri, Oct 17, 2008 at 10:28:58AM +0100, Alan Cox wrote:
> Different discussion and different patches. We can get patches in for the
> crystal frequency stuff and then debate the rest later

In that case, here is the crystal frequency patch (typos fixed and
proper sign off line).

Signed-off-by: Don Dugger <donald.d.dugger@intel.com>

 Documentation/kernel-parameters.txt |   13 ++++++++-----
 drivers/serial/8250_early.c         |    5 +++++
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 2443f5b..bf6dd6f 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -505,12 +505,15 @@ and is between 256 and 4096 characters. It is defined in the file
 			Documentation/networking/netconsole.txt for an
 			alternative.
 
-		uart[8250],io,<addr>[,options]
-		uart[8250],mmio,<addr>[,options]
+		uart[8250],io,<addr>[,options[,clk]]
+		uart[8250],mmio,<addr>[,options[,clk]]
 			Start an early, polled-mode console on the 8250/16550
 			UART at the specified I/O port or MMIO address,
 			switching to the matching ttyS device later.  The
-			options are the same as for ttyS, above.
+			"options" are the same as for ttyS, above.  "clk"
+			is the crystal frequency which defaults to 115200
+			(typically the fastest baud rate supported by the
+			uart) but some hardware use different crystals.
 
                 If the device connected to the port is not a TTY but a braille
                 device, prepend "brl," before the device type, for instance
@@ -518,8 +521,8 @@ and is between 256 and 4096 characters. It is defined in the file
 		For now, only VisioBraille is supported.
 
 	earlycon=	[KNL] Output early console device and options.
-		uart[8250],io,<addr>[,options]
-		uart[8250],mmio,<addr>[,options]
+		uart[8250],io,<addr>[,options,[clk]]
+		uart[8250],mmio,<addr>[,options,[clk]]
 			Start an early, polled-mode console on the 8250/16550
 			UART at the specified I/O port or MMIO address.
 			The options are the same as for ttyS, above.
diff --git a/drivers/serial/8250_early.c b/drivers/serial/8250_early.c
index f279745..edd5803 100644
--- a/drivers/serial/8250_early.c
+++ b/drivers/serial/8250_early.c
@@ -180,6 +180,11 @@ static int __init parse_options(struct early_serial8250_device *device,
 		snprintf(device->options, sizeof(device->options), "%u",
 			device->baud);
 	}
+	options = strchr(options, ',');
+	if (options) {
+		options++;
+		port->uartclk = simple_strtoul(options, NULL, 0) * 16;
+	}
 
 	printk(KERN_INFO "Early serial console at %s 0x%llx (options '%s')\n",
 		mmio ? "MMIO" : "I/O port",

  reply	other threads:[~2008-10-17 14:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14 22:31 donald.d.dugger
2008-10-14 22:39 ` Yinghai Lu
2008-10-14 23:30   ` n0ano
2008-10-15  9:13     ` Paul Bolle
2008-10-15 20:48       ` n0ano
2008-10-16 10:43         ` Paul Bolle
2008-10-16 16:23           ` Yinghai Lu
2008-10-16 17:12             ` n0ano
2008-10-16 18:19               ` Yinghai Lu
2008-10-16 18:25                 ` n0ano
2008-10-16 18:30                   ` Yinghai Lu
2008-10-16 18:57                     ` n0ano
2008-10-17  2:45                     ` n0ano
2008-10-17  3:32                       ` Yinghai Lu
2008-10-17 16:05                         ` n0ano
2008-10-17 17:01                           ` Yinghai Lu
2008-10-14 22:53 ` Alan Cox
2008-10-14 23:04   ` n0ano
2008-10-16 23:16 ` Bjorn Helgaas
2008-10-17  2:39   ` n0ano
2008-10-17  9:28     ` Alan Cox
2008-10-17 14:11       ` n0ano [this message]
2008-10-17 14:46         ` Bjorn Helgaas
2008-10-17 15:36           ` n0ano
2008-10-17 16:39             ` Bjorn Helgaas
2008-10-17 17:06               ` n0ano
2008-10-20 16:44                 ` Lennart Sorensen
2008-10-20 17:11                   ` Bjorn Helgaas
2008-10-20 17:43                     ` n0ano
2008-10-20 19:11                       ` Bjorn Helgaas
2008-10-21 20:08                         ` n0ano
2008-10-21 22:08                           ` Bjorn Helgaas
2008-10-21 22:33                             ` n0ano
2008-10-17 14:44     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081017141102.GG14490@xolotl.n0ano.com \
    --to=n0ano@n0ano.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bjorn.helgaas@hp.com \
    --cc=donald.d.dugger@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®