From: Christoph Hellwig <hch@infradead.org>
To: Wolfgang Kroworsch <wolfgang@kroworsch.de>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] vt: incomplete initialization of vc_tab_stop
Date: Sat, 18 Oct 2008 07:57:12 -0400 [thread overview]
Message-ID: <20081018115712.GA16600@infradead.org> (raw)
In-Reply-To: <20081018114929.GA25554@kroworsch.de>
On Sat, Oct 18, 2008 at 01:49:31PM +0200, Wolfgang Kroworsch wrote:
> vc->vc_tab_stop[1] =
> vc->vc_tab_stop[2] =
> vc->vc_tab_stop[3] =
> - vc->vc_tab_stop[4] = 0x01010101;
> + vc->vc_tab_stop[4] =
> + vc->vc_tab_stop[5] =
> + vc->vc_tab_stop[6] =
> + vc->vc_tab_stop[7] = 0x01010101;
>
> + vc->vc_tab_stop[4] =
> + vc->vc_tab_stop[5] =
> + vc->vc_tab_stop[6] =
> + vc->vc_tab_stop[7] = 0;
Using memset might be a beter idea.
next prev parent reply other threads:[~2008-10-18 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-18 11:49 Wolfgang Kroworsch
2008-10-18 11:57 ` Christoph Hellwig [this message]
2008-10-22 10:27 ` Alan Cox
2008-10-22 18:03 ` Wolfgang Kroworsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081018115712.GA16600@infradead.org \
--to=hch@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=wolfgang@kroworsch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome