From: Wolfgang Kroworsch <wolfgang@kroworsch.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vt: incomplete initialization of vc_tab_stop
Date: Wed, 22 Oct 2008 20:03:01 +0200 [thread overview]
Message-ID: <20081022180301.GA10627@kroworsch.de> (raw)
In-Reply-To: <20081022112705.10f9aa4a@lxorguk.ukuu.org.uk>
On Wed, Oct 22, 2008 at 11:27:05AM +0100 Alan Cox wrote:
> On Sat, 18 Oct 2008 13:49:31 +0200 Wolfgang Kroworsch wrote:
>
> > Problem 1 (see patch below):
> > vc_tab_stop is declared as an array of 8 unsigned ints in struct
> > vc_data in include/linux/console_struct.h .
> > In drivers/char/vt.c only 5 of these 8 unsigned ints get initialized
> > leading to unintended tabulator placement on displays with more than
> > 160 columns text.
>
> Seems sensible enough - but need a Signed-off-by line to apply.
Thx, Wolfgang
Signed-off-by: Wolfgang Kroworsch <wolfgang@kroworsch.de>
---
drivers/char/vt.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index d8f83e2..a5af607 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -1644,7 +1644,10 @@ static void reset_terminal(struct vc_data *vc, int do_clear)
vc->vc_tab_stop[1] =
vc->vc_tab_stop[2] =
vc->vc_tab_stop[3] =
- vc->vc_tab_stop[4] = 0x01010101;
+ vc->vc_tab_stop[4] =
+ vc->vc_tab_stop[5] =
+ vc->vc_tab_stop[6] =
+ vc->vc_tab_stop[7] = 0x01010101;
vc->vc_bell_pitch = DEFAULT_BELL_PITCH;
vc->vc_bell_duration = DEFAULT_BELL_DURATION;
@@ -1935,7 +1938,10 @@ static void do_con_trol(struct tty_struct *tty, struct vc_data *vc, int c)
vc->vc_tab_stop[1] =
vc->vc_tab_stop[2] =
vc->vc_tab_stop[3] =
- vc->vc_tab_stop[4] = 0;
+ vc->vc_tab_stop[4] =
+ vc->vc_tab_stop[5] =
+ vc->vc_tab_stop[6] =
+ vc->vc_tab_stop[7] = 0;
}
return;
case 'm':
prev parent reply other threads:[~2008-10-22 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-18 11:49 Wolfgang Kroworsch
2008-10-18 11:57 ` Christoph Hellwig
2008-10-22 10:27 ` Alan Cox
2008-10-22 18:03 ` Wolfgang Kroworsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022180301.GA10627@kroworsch.de \
--to=wolfgang@kroworsch.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome