* [PATCH] pci: use pci_ioremap_bar() in drivers/mmc
@ 2008-10-21 4:56 Arjan van de Ven
2008-10-26 11:48 ` Pierre Ossman
0 siblings, 1 reply; 2+ messages in thread
From: Arjan van de Ven @ 2008-10-21 4:56 UTC (permalink / raw)
To: drzeus-mmc; +Cc: linux-kernel, akpm
>From 6fc220a25ecbb0576179c6b4472e7262389b25e8 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@linux.intel.com>
Date: Sun, 28 Sep 2008 16:15:56 -0700
Subject: [PATCH] pci: use pci_ioremap_bar() in drivers/mmc
Use the new pci_ioremap_bar() function in drivers/mmc.
pci_ioremap_bar() just takes a pci device and a bar number, with the goal
of making it really hard to get wrong, while also having a central place
to stick sanity checks.
CC: Pierre Ossman <drzeus@drzeus.cx>
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
drivers/mmc/host/sdhci-pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
index 9bd7026..f07255c 100644
--- a/drivers/mmc/host/sdhci-pci.c
+++ b/drivers/mmc/host/sdhci-pci.c
@@ -545,7 +545,7 @@ static struct sdhci_pci_slot * __devinit sdhci_pci_probe_slot(
}
addr = pci_resource_start(pdev, bar);
- host->ioaddr = ioremap_nocache(addr, pci_resource_len(pdev, bar));
+ host->ioaddr = pci_ioremap_bar(pdev, bar);
if (!host->ioaddr) {
dev_err(&pdev->dev, "failed to remap registers\n");
goto release;
--
1.5.5.1
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] pci: use pci_ioremap_bar() in drivers/mmc
2008-10-21 4:56 [PATCH] pci: use pci_ioremap_bar() in drivers/mmc Arjan van de Ven
@ 2008-10-26 11:48 ` Pierre Ossman
0 siblings, 0 replies; 2+ messages in thread
From: Pierre Ossman @ 2008-10-26 11:48 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: linux-kernel, akpm
On Mon, 20 Oct 2008 21:56:24 -0700
Arjan van de Ven <arjan@infradead.org> wrote:
> From 6fc220a25ecbb0576179c6b4472e7262389b25e8 Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@linux.intel.com>
> Date: Sun, 28 Sep 2008 16:15:56 -0700
> Subject: [PATCH] pci: use pci_ioremap_bar() in drivers/mmc
>
> Use the new pci_ioremap_bar() function in drivers/mmc.
> pci_ioremap_bar() just takes a pci device and a bar number, with the goal
> of making it really hard to get wrong, while also having a central place
> to stick sanity checks.
>
> CC: Pierre Ossman <drzeus@drzeus.cx>
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> ---
Looks sane. Queued.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-26 11:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-21 4:56 [PATCH] pci: use pci_ioremap_bar() in drivers/mmc Arjan van de Ven
2008-10-26 11:48 ` Pierre Ossman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®