* [PATCH 2/2] bfs: check that filesystem fits on the blockdevice
@ 2008-10-21 10:51 Eric Sesterhenn
0 siblings, 0 replies; only message in thread
From: Eric Sesterhenn @ 2008-10-21 10:51 UTC (permalink / raw)
To: akpm; +Cc: tigran, linux-kernel
Since all sanity checks rely on the validity of s_start which gets only
checked to be smaller than s_end, we should also check if s_end is sane.
Now we also try to retrieve the last block of the filesystem, which is
computed by s_end. If this fails, something is bogus.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
--- linux/fs/bfs/inode.c.1 2008-09-17 16:00:06.000000000 +0200
+++ linux/fs/bfs/inode.c 2008-09-17 16:17:54.000000000 +0200
@@ -390,6 +390,18 @@ static int bfs_fill_super(struct super_b
- le32_to_cpu(bfs_sb->s_start)) >> BFS_BSIZE_BITS;
info->si_freei = 0;
info->si_lf_eblk = 0;
+
+ /* can we read the last block? */
+ bh = sb_bread(s, info->si_blocks - 1);
+ if (!bh) {
+ printf("Last block not available: %lu\n", info->si_blocks - 1);
+ iput(inode);
+ ret = -EIO;
+ kfree(info->si_imap);
+ goto out;
+ }
+ brelse(bh);
+
bh = NULL;
for (i = BFS_ROOT_INO; i <= info->si_lasti; i++) {
struct bfs_inode *di;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-10-21 10:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-21 10:51 [PATCH 2/2] bfs: check that filesystem fits on the blockdevice Eric Sesterhenn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®