[PATCH] trace: create tracers menu

[PATCH] trace: create tracers menu

[Peter Zijlstra]

Subject: trace: create tracers menu
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date: Tue Oct 21 16:26:36 CEST 2008

We seem to have plenty tracers, lets create a menu and not clutter
the already cluttered debug menu more.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
 kernel/trace/Kconfig |    4 ++++
 1 file changed, 4 insertions(+)

Index: linux-2.6/kernel/trace/Kconfig
===================================================================
--- linux-2.6.orig/kernel/trace/Kconfig
+++ linux-2.6/kernel/trace/Kconfig
@@ -29,6 +29,8 @@ config TRACING
 	select STACKTRACE
 	select TRACEPOINTS
 
+menu "Tracers"
+
 config FUNCTION_TRACER
 	bool "Kernel Function Tracer"
 	depends on HAVE_FUNCTION_TRACER
@@ -191,3 +193,5 @@ config FTRACE_STARTUP_TEST
 	  a series of tests are made to verify that the tracer is
 	  functioning properly. It will do tests on all the configured
 	  tracers of ftrace.
+
+endmenu

Re: [PATCH] trace: create tracers menu

[Frédéric Weisbecker]

2008/10/21 Peter Zijlstra <peterz@infradead.org>:
> Subject: trace: create tracers menu
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Tue Oct 21 16:26:36 CEST 2008
>
> We seem to have plenty tracers, lets create a menu and not clutter
> the already cluttered debug menu more.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
>  kernel/trace/Kconfig |    4 ++++
>  1 file changed, 4 insertions(+)
>
> Index: linux-2.6/kernel/trace/Kconfig
> ===================================================================
> --- linux-2.6.orig/kernel/trace/Kconfig
> +++ linux-2.6/kernel/trace/Kconfig
> @@ -29,6 +29,8 @@ config TRACING
>        select STACKTRACE
>        select TRACEPOINTS
>
> +menu "Tracers"
> +
>  config FUNCTION_TRACER
>        bool "Kernel Function Tracer"
>        depends on HAVE_FUNCTION_TRACER
> @@ -191,3 +193,5 @@ config FTRACE_STARTUP_TEST
>          a series of tests are made to verify that the tracer is
>          functioning properly. It will do tests on all the configured
>          tracers of ftrace.
> +
> +endmenu


Good Idea :)

Re: [PATCH] trace: create tracers menu

[Frédéric Weisbecker]

2008/10/21 Frédéric Weisbecker <fweisbec@gmail.com>:
> 2008/10/21 Peter Zijlstra <peterz@infradead.org>:
>> Subject: trace: create tracers menu
>> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
>> Date: Tue Oct 21 16:26:36 CEST 2008
>>
>> We seem to have plenty tracers, lets create a menu and not clutter
>> the already cluttered debug menu more.

But...you just included the function tracer inside?

Re: [PATCH] trace: create tracers menu

[Steven Rostedt]

On Tue, 21 Oct 2008, Peter Zijlstra wrote:

> Subject: trace: create tracers menu
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Tue Oct 21 16:26:36 CEST 2008
> 
> We seem to have plenty tracers, lets create a menu and not clutter
> the already cluttered debug menu more.
> 
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>

Acked-by: Steven Rostedt <srostedt@redhat.com>

-- Steve

Re: [PATCH] trace: create tracers menu

[Peter Zijlstra]

On Tue, 2008-10-21 at 16:37 +0200, Frédéric Weisbecker wrote:
> 2008/10/21 Frédéric Weisbecker <fweisbec@gmail.com>:
> > 2008/10/21 Peter Zijlstra <peterz@infradead.org>:
> >> Subject: trace: create tracers menu
> >> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> >> Date: Tue Oct 21 16:26:36 CEST 2008
> >>
> >> We seem to have plenty tracers, lets create a menu and not clutter
> >> the already cluttered debug menu more.
> 
> But...you just included the function tracer inside?

Problem being? That's a tracer too, right? And it doesn't seem required
by the other tracers (except the max stack tracer).

Re: [PATCH] trace: create tracers menu

[Steven Rostedt]

On Tue, 21 Oct 2008, Fr?d?ric Weisbecker wrote:

> 2008/10/21 Fr?d?ric Weisbecker <fweisbec@gmail.com>:
> > 2008/10/21 Peter Zijlstra <peterz@infradead.org>:
> >> Subject: trace: create tracers menu
> >> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> >> Date: Tue Oct 21 16:26:36 CEST 2008
> >>
> >> We seem to have plenty tracers, lets create a menu and not clutter
> >> the already cluttered debug menu more.
> 
> But...you just included the function tracer inside?

Sure, why not? The function tracer is its own tracer itself.

-- Steve

Re: [PATCH] trace: create tracers menu

[Frédéric Weisbecker]

2008/10/21 Peter Zijlstra <peterz@infradead.org>:
> Problem being? That's a tracer too, right? And it doesn't seem required
> by the other tracers (except the max stack tracer).


Sorry I didn't want to write "just" but "only". I misread the patch
and I believed
there only was the function tracer inside.

Re: [PATCH] trace: create tracers menu

[Ingo Molnar]

* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 21 Oct 2008, Peter Zijlstra wrote:
> 
> > Subject: trace: create tracers menu
> > From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Date: Tue Oct 21 16:26:36 CEST 2008
> > 
> > We seem to have plenty tracers, lets create a menu and not clutter
> > the already cluttered debug menu more.
> > 
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> 
> Acked-by: Steven Rostedt <srostedt@redhat.com>

applied to tip/tracing/urgent, thanks!

	Ingo