mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] pci: PCI_QUIRKS depends on PCI
@ 2008-10-22  6:53 Geert Uytterhoeven
  2008-10-22 22:45 ` Jesse Barnes
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2008-10-22  6:53 UTC (permalink / raw)
  To: Thomas Petazzoni, Jesse Barnes; +Cc: linux-pci, Linux Kernel Development

commit 3d137310245e4cdc3e8c8ba1bea2e145a87ae8e3 ("PCI: allow quirks to be
compiled out") introduced CONFIG_PCI_QUIRKS, which now shows up in each
and every .config.

Probably the intention was to make the PCI_QUIRKS symbol depend on PCI, not
on its selection enabler?

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 init/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/init/Kconfig
+++ b/init/Kconfig
@@ -739,7 +739,8 @@ config VM_EVENT_COUNTERS
 
 config PCI_QUIRKS
 	default y
-	bool "Enable PCI quirk workarounds" if EMBEDDED && PCI
+	bool "Enable PCI quirk workarounds" if EMBEDDED
+	depends on PCI
 	help
 	  This enables workarounds for various PCI chipset
           bugs/quirks. Disable this only if your target machine is

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] pci: PCI_QUIRKS depends on PCI
  2008-10-22  6:53 [PATCH] pci: PCI_QUIRKS depends on PCI Geert Uytterhoeven
@ 2008-10-22 22:45 ` Jesse Barnes
  0 siblings, 0 replies; 2+ messages in thread
From: Jesse Barnes @ 2008-10-22 22:45 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Thomas Petazzoni, linux-pci, Linux Kernel Development

On Tuesday, October 21, 2008 11:53 pm Geert Uytterhoeven wrote:
> commit 3d137310245e4cdc3e8c8ba1bea2e145a87ae8e3 ("PCI: allow quirks to be
> compiled out") introduced CONFIG_PCI_QUIRKS, which now shows up in each
> and every .config.
>
> Probably the intention was to make the PCI_QUIRKS symbol depend on PCI, not
> on its selection enabler?
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Yeah, that works.  Thanks Geert.

Jesse

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-22 22:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-22  6:53 [PATCH] pci: PCI_QUIRKS depends on PCI Geert Uytterhoeven
2008-10-22 22:45 ` Jesse Barnes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®