From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Laurent Pinchart <laurent.pinchart@skynet.be>,
linux-kernel@vger.kernel.org, airlied@linux.ie, perex@perex.cz,
alan-jenkins@tuffmail.co.uk
Subject: Re: [PATCH] Check fops_get() return value
Date: Fri, 24 Oct 2008 12:33:15 -0200 [thread overview]
Message-ID: <20081024123315.5ca3bc83@pedra.chehab.org> (raw)
In-Reply-To: <s5hzll41xgf.wl%tiwai@suse.de>
On Thu, 16 Oct 2008 15:28:00 +0200
Takashi Iwai <tiwai@suse.de> wrote:
> >
> > old_fops = filp->f_op;
> > filp->f_op = fops_get(&dev->driver->fops);
> > + if (filp->f_op == NULL) {
>
> I think the more standard style is
>
> if (!file->fop) {
Yes. This seems a good cleanup to the patch.
>
> Except for that minor issue, it looks good to me.
> In any case,
>
> Acked-by: Takashi Iwai <tiwai@suse.de>
You have my ack also.
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Cheers,
Mauro
prev parent reply other threads:[~2008-10-24 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 13:02 Laurent Pinchart
2008-10-16 13:28 ` Takashi Iwai
2008-10-24 14:33 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024123315.5ca3bc83@pedra.chehab.org \
--to=mchehab@infradead.org \
--cc=airlied@linux.ie \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=laurent.pinchart@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®