* [PATCH 4/6] w35und: remove abs() and BIT() macros
@ 2008-10-29 18:11 Pekka J Enberg
2008-10-29 21:38 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Pekka J Enberg @ 2008-10-29 18:11 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Pavel Machek, linux-kernel
From: Pekka Enberg <penberg@cs.helsinki.fi>
We can use the kernel built-in abs() and BIT() macros the just fine.
Cc: Pavel Machek <pavel@suse.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
---
drivers/staging/winbond/linux/common.h | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/winbond/linux/common.h b/drivers/staging/winbond/linux/common.h
index 046dab6..f171b88 100644
--- a/drivers/staging/winbond/linux/common.h
+++ b/drivers/staging/winbond/linux/common.h
@@ -48,16 +48,9 @@
#define STATUS_MEDIA_CONNECT 1
#define STATUS_MEDIA_DISCONNECT 0
-#ifndef BIT
-#define BIT(x) (1 << (x))
-#endif
-
//==================================================================================================
// Common function definition
//==================================================================================================
-#ifndef abs
-#define abs(_T) ((_T) < 0 ? -_T : _T)
-#endif
#define DEBUG_ENABLED
#define ETH_LENGTH_OF_ADDRESS 6
#ifdef DEBUG_ENABLED
--
1.5.3.7
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 4/6] w35und: remove abs() and BIT() macros
2008-10-29 18:11 [PATCH 4/6] w35und: remove abs() and BIT() macros Pekka J Enberg
@ 2008-10-29 21:38 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2008-10-29 21:38 UTC (permalink / raw)
To: Pekka J Enberg; +Cc: Greg Kroah-Hartman, linux-kernel
On Wed 2008-10-29 20:11:13, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
>
> We can use the kernel built-in abs() and BIT() macros the just fine.
>
Acked-by: Pavel Machek <pavel@suse.cz>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-29 21:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-29 18:11 [PATCH 4/6] w35und: remove abs() and BIT() macros Pekka J Enberg
2008-10-29 21:38 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®