From: Alexey Dobriyan <adobriyan@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ken Chen <kenchen@google.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [patch] add /proc/pid/stack to dump task's stack trace
Date: Fri, 7 Nov 2008 11:20:03 +0300 [thread overview]
Message-ID: <20081107082003.GA15800@x200.localdomain> (raw)
In-Reply-To: <20081107075925.GA1825@elte.hu>
On Fri, Nov 07, 2008 at 08:59:25AM +0100, Ingo Molnar wrote:
>
> * Ingo Molnar <mingo@elte.hu> wrote:
>
> > > > + * buffer size used for proc read. See proc_info_read().
> > > > + * 4K page size but our output routines use some slack for overruns
> > > > + */
> > > > +#define PROC_BLOCK_SIZE (3*1024)
> >
> > That sounds like a proper limit - the hard limit for this particular
> > printout function is 4096-170, so we are well within the
> > PROC_BLOCK_SIZE range.
>
> ok, i've added Ken's patch to tip/core/stacktrace and started testing
> it.
>
> Alexey, i've added your Acked-by because you appeared to like the
> patch - let me know if i should remove it.
Of course, I don't like it!
Switch to seqfiles, add entry in TID table as well.
The idea is good, though.
next prev parent reply other threads:[~2008-11-07 8:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 19:01 Ken Chen
2008-11-06 19:51 ` Alexey Dobriyan
2008-11-06 20:12 ` Ken Chen
2008-11-06 20:35 ` Ingo Molnar
2008-11-07 0:30 ` Ken Chen
2008-11-07 0:48 ` Alexey Dobriyan
2008-11-07 7:41 ` Ingo Molnar
2008-11-07 7:59 ` Ingo Molnar
2008-11-07 8:20 ` Alexey Dobriyan [this message]
2008-11-07 8:32 ` Ingo Molnar
2008-11-07 8:49 ` Alexey Dobriyan
2008-11-07 8:53 ` Ingo Molnar
2008-11-07 9:03 ` Ingo Molnar
2008-11-07 9:16 ` Andrew Morton
2008-11-07 9:29 ` Ingo Molnar
2008-11-07 17:51 ` Alexey Dobriyan
2008-11-08 12:06 ` Ingo Molnar
2008-11-10 23:54 ` Andrew Morton
2008-11-11 10:00 ` Ingo Molnar
2008-11-11 12:25 ` Marcin Slusarz
2008-11-11 12:33 ` Alexey Dobriyan
2008-11-11 13:20 ` Ingo Molnar
2008-11-11 14:03 ` Mikael Pettersson
2008-11-11 14:19 ` Ingo Molnar
2008-11-07 18:38 ` Ken Chen
2008-11-07 18:46 ` Paul Menage
2008-11-08 12:10 ` Ingo Molnar
2008-11-09 18:08 ` Alexey Dobriyan
2008-11-10 8:41 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107082003.GA15800@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®