From: Paul Menage <menage@google.com>
To: Ken Chen <kenchen@google.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [patch] add /proc/pid/stack to dump task's stack trace
Date: Fri, 7 Nov 2008 10:46:11 -0800 [thread overview]
Message-ID: <6599ad830811071046w30111c42refcc2287a154a1e@mail.gmail.com> (raw)
In-Reply-To: <b040c32a0811071038g5e6faba6n55b22e52e1d2ea98@mail.gmail.com>
On Fri, Nov 7, 2008 at 10:38 AM, Ken Chen <kenchen@google.com> wrote:
>
> Here is a patch convert to seq_file using proc_single_show() helper.
> I don't see it to be any superior than what was before using
> snprintf(). seq_read also allocate one page for printf buffer, so
> functionally it is the same (perhaps a little bit better because it
> can use the whole page, compare to PROC_BLOCK_SIZE currently).
No - if you exceed the original buffer size, the seq_file system will
double up the memory buffer and try again if necessary.
Paul
next prev parent reply other threads:[~2008-11-07 18:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 19:01 Ken Chen
2008-11-06 19:51 ` Alexey Dobriyan
2008-11-06 20:12 ` Ken Chen
2008-11-06 20:35 ` Ingo Molnar
2008-11-07 0:30 ` Ken Chen
2008-11-07 0:48 ` Alexey Dobriyan
2008-11-07 7:41 ` Ingo Molnar
2008-11-07 7:59 ` Ingo Molnar
2008-11-07 8:20 ` Alexey Dobriyan
2008-11-07 8:32 ` Ingo Molnar
2008-11-07 8:49 ` Alexey Dobriyan
2008-11-07 8:53 ` Ingo Molnar
2008-11-07 9:03 ` Ingo Molnar
2008-11-07 9:16 ` Andrew Morton
2008-11-07 9:29 ` Ingo Molnar
2008-11-07 17:51 ` Alexey Dobriyan
2008-11-08 12:06 ` Ingo Molnar
2008-11-10 23:54 ` Andrew Morton
2008-11-11 10:00 ` Ingo Molnar
2008-11-11 12:25 ` Marcin Slusarz
2008-11-11 12:33 ` Alexey Dobriyan
2008-11-11 13:20 ` Ingo Molnar
2008-11-11 14:03 ` Mikael Pettersson
2008-11-11 14:19 ` Ingo Molnar
2008-11-07 18:38 ` Ken Chen
2008-11-07 18:46 ` Paul Menage [this message]
2008-11-08 12:10 ` Ingo Molnar
2008-11-09 18:08 ` Alexey Dobriyan
2008-11-10 8:41 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830811071046w30111c42refcc2287a154a1e@mail.gmail.com \
--to=menage@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®