From: Alasdair G Kergon <agk@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
axboe@kernel.dk, dm-devel <dm-devel@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: Queue upcall locking (was: [dm-devel] [RFC][PATCH] fix dm_any_congested() to properly sync up with suspend code path)
Date: Mon, 10 Nov 2008 14:27:15 +0000 [thread overview]
Message-ID: <20081110142715.GD16649@agk.fab.redhat.com> (raw)
In-Reply-To: <20081110135401.GA11606@infradead.org>
On Mon, Nov 10, 2008 at 08:54:01AM -0500, Christoph Hellwig wrote:
> On Mon, Nov 10, 2008 at 08:11:51AM -0500, Mikulas Patocka wrote:
> > For upstream Linux developers: you are holding a spinlock and calling
> > bdi*_congested functions that can take indefinite amount of time (there
> > are even users reporting having 50 disks in one logical volume or so). I
> > think it would be good to move these calls out of spinlocks.
> Umm, they shouldn't block that long, as that completely defeats their
> purpose.
Indeed - the blocking was a bug for which there's a patch, but that doesn't
deal with how the function should be operating in the first place.
- If one device is found to be congested, why bother checking the remaining
devices?
- If the device is suspended, the response should be that it is congested, I'd
have thought.
Alasdair
--
agk@redhat.com
next prev parent reply other threads:[~2008-11-10 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1225944008.14830.1101.camel@chandra-ubuntu>
2008-11-10 13:11 ` Mikulas Patocka
2008-11-10 13:54 ` Christoph Hellwig
2008-11-10 14:19 ` Mikulas Patocka
2008-11-10 14:26 ` Peter Zijlstra
2008-11-10 14:32 ` Mikulas Patocka
2008-11-10 14:46 ` Peter Zijlstra
2008-11-10 14:55 ` Mikulas Patocka
2008-11-10 14:35 ` Alasdair G Kergon
2008-11-11 18:18 ` Christoph Hellwig
2008-11-11 22:08 ` Mikulas Patocka
2008-11-10 14:27 ` Alasdair G Kergon [this message]
2008-11-10 14:40 ` Mikulas Patocka
2008-11-11 18:22 ` Christoph Hellwig
2008-11-11 18:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081110142715.GD16649@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®