From: Christoph Hellwig <hch@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Chandra Seetharaman <sekharan@us.ibm.com>,
Alasdair G Kergon <agk@redhat.com>,
dm-devel <dm-devel@redhat.com>,
linux-kernel@vger.kernel.org, axboe@kernel.dk
Subject: Re: Queue upcall locking (was: [dm-devel] [RFC][PATCH] fix dm_any_congested() to properly sync up with suspend code path)
Date: Tue, 11 Nov 2008 13:18:54 -0500 [thread overview]
Message-ID: <20081111181854.GA25049@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0811100914500.14825@hs20-bc2-1.build.redhat.com>
On Mon, Nov 10, 2008 at 09:19:21AM -0500, Mikulas Patocka wrote:
> For device mapper, congested_fn asks every device in the tree and make OR
> of their bits --- so if the user has 50 devices, it asks them all.
>
> For md-linear, md-raid0, md-raid1, md-raid10 and md-multipath it does the
> same --- asking every device.
>
> If you have a better idea how to implement congested_fn, say it.
Well, even asking 50 devices shouldn't take that long normally. Do you
take some sleeping lock that might block forever? In that case I would
just return congested for that device as it would delay pdflush
otherwise.
next prev parent reply other threads:[~2008-11-11 18:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1225944008.14830.1101.camel@chandra-ubuntu>
2008-11-10 13:11 ` Mikulas Patocka
2008-11-10 13:54 ` Christoph Hellwig
2008-11-10 14:19 ` Mikulas Patocka
2008-11-10 14:26 ` Peter Zijlstra
2008-11-10 14:32 ` Mikulas Patocka
2008-11-10 14:46 ` Peter Zijlstra
2008-11-10 14:55 ` Mikulas Patocka
2008-11-10 14:35 ` Alasdair G Kergon
2008-11-11 18:18 ` Christoph Hellwig [this message]
2008-11-11 22:08 ` Mikulas Patocka
2008-11-10 14:27 ` Alasdair G Kergon
2008-11-10 14:40 ` Mikulas Patocka
2008-11-11 18:22 ` Christoph Hellwig
2008-11-11 18:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081111181854.GA25049@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=sekharan@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®