[PATCH] x86: Make NUMA on 32-bit depend on BROKEN

[PATCH] x86: Make NUMA on 32-bit depend on BROKEN

[Rafael J. Wysocki]

From: Rafael J. Wysocki <rjw@sisk.pl>
Subject: x86: Make NUMA on 32-bit depend on BROKEN

While investigating the failure of hibernation on 32-bit x86 with
CONFIG_NUMA set, as described in this message
http://marc.info/?l=linux-kernel&m=122634118116226&w=4
I asked some people for help and I was told that it wasn't really
worth the effort, because CONFIG_NUMA was generally broken on 32-bit
x86 systems and it shouldn't be used in such configs.  For this
reason, make CONFIG_NUMA depend on BROKEN instead of EXPERIMENTAL on
x86-32.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Pavel Machek <pavel@suse.cz>
Cc: Peter Zijlstra <peterz@infradead.org>
---
 arch/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/arch/x86/Kconfig
===================================================================
--- linux-2.6.orig/arch/x86/Kconfig
+++ linux-2.6/arch/x86/Kconfig
@@ -957,7 +957,7 @@ config ARCH_PHYS_ADDR_T_64BIT
 config NUMA
 	bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)"
 	depends on SMP
-	depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_BIGSMP || X86_SUMMIT && ACPI) && EXPERIMENTAL)
+	depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_BIGSMP || X86_SUMMIT && ACPI) && BROKEN)
 	default n if X86_PC
 	default y if (X86_NUMAQ || X86_SUMMIT || X86_BIGSMP)
 	help

Re: [PATCH] x86: Make NUMA on 32-bit depend on BROKEN

[Pavel Machek]

> From: Rafael J. Wysocki <rjw@sisk.pl>
> Subject: x86: Make NUMA on 32-bit depend on BROKEN
> 
> While investigating the failure of hibernation on 32-bit x86 with
> CONFIG_NUMA set, as described in this message
> http://marc.info/?l=linux-kernel&m=122634118116226&w=4
> I asked some people for help and I was told that it wasn't really
> worth the effort, because CONFIG_NUMA was generally broken on 32-bit
> x86 systems and it shouldn't be used in such configs.  For this
> reason, make CONFIG_NUMA depend on BROKEN instead of EXPERIMENTAL on
> x86-32.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: Andi Kleen <andi@firstfloor.org>
> Cc: Pavel Machek <pavel@suse.cz>

ACK.

> Cc: Peter Zijlstra <peterz@infradead.org>
> ---
>  arch/x86/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/arch/x86/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/x86/Kconfig
> +++ linux-2.6/arch/x86/Kconfig
> @@ -957,7 +957,7 @@ config ARCH_PHYS_ADDR_T_64BIT
>  config NUMA
>  	bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)"
>  	depends on SMP
> -	depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_BIGSMP || X86_SUMMIT && ACPI) && EXPERIMENTAL)
> +	depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_BIGSMP || X86_SUMMIT && ACPI) && BROKEN)
>  	default n if X86_PC
>  	default y if (X86_NUMAQ || X86_SUMMIT || X86_BIGSMP)
>  	help

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] x86: Make NUMA on 32-bit depend on BROKEN

[Ingo Molnar]

* Rafael J. Wysocki <rjw@sisk.pl> wrote:

> From: Rafael J. Wysocki <rjw@sisk.pl>
> Subject: x86: Make NUMA on 32-bit depend on BROKEN
> 
> While investigating the failure of hibernation on 32-bit x86 with 
> CONFIG_NUMA set, as described in this message 
> http://marc.info/?l=linux-kernel&m=122634118116226&w=4 I asked some 
> people for help and I was told that it wasn't really worth the 
> effort, because CONFIG_NUMA was generally broken on 32-bit x86 
> systems and it shouldn't be used in such configs.  For this reason, 
> make CONFIG_NUMA depend on BROKEN instead of EXPERIMENTAL on x86-32.

Actually, it works just fine on a wide range of 32-bit systems that i 
have, so NAK.

Hibernation might not work but that's i believe a NUMA<->HIBERNATION 
interaction issue, we need to fix that. Regular system bootup and 
stress-tests work just fine.

	Ingo

Re: [PATCH] x86: Make NUMA on 32-bit depend on BROKEN

[Rafael J. Wysocki]

On Tuesday, 11 of November 2008, Ingo Molnar wrote:
> 
> * Rafael J. Wysocki <rjw@sisk.pl> wrote:
> 
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> > Subject: x86: Make NUMA on 32-bit depend on BROKEN
> > 
> > While investigating the failure of hibernation on 32-bit x86 with 
> > CONFIG_NUMA set, as described in this message 
> > http://marc.info/?l=linux-kernel&m=122634118116226&w=4 I asked some 
> > people for help and I was told that it wasn't really worth the 
> > effort, because CONFIG_NUMA was generally broken on 32-bit x86 
> > systems and it shouldn't be used in such configs.  For this reason, 
> > make CONFIG_NUMA depend on BROKEN instead of EXPERIMENTAL on x86-32.
> 
> Actually, it works just fine on a wide range of 32-bit systems that i 
> have, so NAK.
> 
> Hibernation might not work but that's i believe a NUMA<->HIBERNATION 
> interaction issue, we need to fix that. Regular system bootup and 
> stress-tests work just fine.

OK, so it seems I'll have to find out what exactly happens. :-(

Thanks,
Rafael