[PATCH mmotm resend] serial/max3100: uses serial core

[PATCH mmotm resend] serial/max3100: uses serial core

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

max3100 driver need to select SERIAL_CORE like most other serial drivers do.

max3100.c:(.text+0x524c5): undefined reference to `uart_write_wakeup'
max3100.c:(.text+0x526eb): undefined reference to `uart_write_wakeup'
max3100.c:(.text+0x529f7): undefined reference to `uart_update_timeout'
max3100.c:(.text+0x52cfa): undefined reference to `uart_resume_port'
max3100.c:(.text+0x52d6a): undefined reference to `uart_suspend_port'
max3100.c:(.devinit.text+0x23e3): undefined reference to `uart_register_driver'
max3100.c:(.devinit.text+0x265a): undefined reference to `uart_add_one_port'
max3100.c:(.devexit.text+0x1aa): undefined reference to `uart_remove_one_port'
max3100.c:(.devexit.text+0x1e5): undefined reference to `uart_unregister_driver'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Christian Pellegrin <chripell@evolware.org>
---
 drivers/serial/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- mmotm-2008-1106-1344.orig/drivers/serial/Kconfig
+++ mmotm-2008-1106-1344/drivers/serial/Kconfig
@@ -511,6 +511,7 @@ config SERIAL_S3C2440
 config SERIAL_MAX3100
         tristate "MAX3100 support"
         depends on SPI
+	select SERIAL_CORE
         help
           MAX3100 chip support
 

Re: mmotm 2008-11-10-14-54 uploaded (i5k_amb)

[Randy Dunlap]

drivers/hwmon/i5K_amb.c contains a few duplicated lines, causing:

mmotm-2008-1112-1148/drivers/hwmon/i5k_amb.c:500: error: redefinition of 'i5k_amb_ids'
mmotm-2008-1112-1148/drivers/hwmon/i5k_amb.c:493: error: previous definition of 'i5k_amb_ids' was here



static struct pci_device_id i5k_amb_ids[] __devinitdata = {
	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5000_ERR) },
	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5400_ERR) },
	{ 0, }
};
MODULE_DEVICE_TABLE(pci, i5k_amb_ids);

static struct pci_device_id i5k_amb_ids[] __devinitdata = {
	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5000_ERR) },
	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5400_ERR) },
	{ 0, },
};

MODULE_DEVICE_TABLE(pci, i5k_amb_ids);

---
~Randy

Re: mmotm 2008-11-10-14-54 uploaded (i5k_amb)

[Andrew Morton]

On Wed, 12 Nov 2008 13:26:40 -0800
Randy Dunlap <rdunlap@xenotime.net> wrote:

> 
> drivers/hwmon/i5K_amb.c contains a few duplicated lines, causing:
> 
> mmotm-2008-1112-1148/drivers/hwmon/i5k_amb.c:500: error: redefinition of 'i5k_amb_ids'
> mmotm-2008-1112-1148/drivers/hwmon/i5k_amb.c:493: error: previous definition of 'i5k_amb_ids' was here
> 
> 
> 
> static struct pci_device_id i5k_amb_ids[] __devinitdata = {
> 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5000_ERR) },
> 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5400_ERR) },
> 	{ 0, }
> };
> MODULE_DEVICE_TABLE(pci, i5k_amb_ids);
> 
> static struct pci_device_id i5k_amb_ids[] __devinitdata = {
> 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5000_ERR) },
> 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5400_ERR) },
> 	{ 0, },
> };
> 
> MODULE_DEVICE_TABLE(pci, i5k_amb_ids);

ok, i5k_amb-load-automatically-on-all-5000-5400-chipsets.patch got
changed then merged via the i2c tree.

Re: mmotm 2008-11-10-14-54 uploaded (RTC)

[Randy Dunlap]

drivers/rtc/rtc-dev.c contains 2 duplicated switch cases:

mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c: In function 'rtc_dev_ioctl':
mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c:421: error: duplicate case value
mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c:372: error: previously used here
mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c:426: error: duplicate case value
mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c:368: error: previously used here

---
~Randy

Re: mmotm 2008-11-10-14-54 uploaded (RTC)

[Andrew Morton]

On Wed, 12 Nov 2008 13:29:05 -0800
Randy Dunlap <rdunlap@xenotime.net> wrote:

> 
> drivers/rtc/rtc-dev.c contains 2 duplicated switch cases:
> 
> mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c: In function 'rtc_dev_ioctl':
> mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c:421: error: duplicate case value
> mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c:372: error: previously used here
> mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c:426: error: duplicate case value
> mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c:368: error: previously used here
> 

Thanks.  rtc-add-alarm-update-irq-interfaces.patch is incompatible with
rtc-rtc-wm8350-add-support-for-wm8350-rtc.patch.  I'll drop
rtc-add-alarm-update-irq-interfaces.patch.

Re: mmotm 2008-11-10-14-54 uploaded (RTC)

[Alessandro Zummo]

On Wed, 12 Nov 2008 13:29:05 -0800
Randy Dunlap <rdunlap@xenotime.net> wrote:

> 
> drivers/rtc/rtc-dev.c contains 2 duplicated switch cases:
> 
> mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c: In function 'rtc_dev_ioctl':
> mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c:421: error: duplicate case value
> mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c:372: error: previously used here
> mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c:426: error: duplicate case value
> mmotm-2008-1112-1148/drivers/rtc/rtc-dev.c:368: error: previously used here

 my fault, fix will follow.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it